400Ping commented on code in PR #734:
URL: https://github.com/apache/mahout/pull/734#discussion_r2630879836
##########
qdp/qdp-core/tests/memory_safety.rs:
##########
@@ -114,15 +118,24 @@ fn test_dlpack_tensor_metadata() {
assert_eq!(stride, 1, "Stride for 1D contiguous array should be 1");
assert_eq!(tensor.dtype.code, 5, "Should be complex type (code=5)");
- assert_eq!(tensor.dtype.bits, 128, "Should be 128 bits (2x64-bit
floats)");
+ assert_eq!(
+ tensor.dtype.bits, 128,
+ "Should be 128 bits (2x64-bit floats)"
+ );
Review Comment:
see [this](https://github.com/apache/mahout/pull/739), working on float32
##########
qdp/qdp-core/tests/memory_safety.rs:
##########
@@ -114,15 +118,24 @@ fn test_dlpack_tensor_metadata() {
assert_eq!(stride, 1, "Stride for 1D contiguous array should be 1");
assert_eq!(tensor.dtype.code, 5, "Should be complex type (code=5)");
- assert_eq!(tensor.dtype.bits, 128, "Should be 128 bits (2x64-bit
floats)");
+ assert_eq!(
+ tensor.dtype.bits, 128,
+ "Should be 128 bits (2x64-bit floats)"
+ );
Review Comment:
see [this](https://github.com/apache/mahout/pull/739), working on float32 rn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
