rich7420 commented on PR #803: URL: https://github.com/apache/mahout/pull/803#issuecomment-3737344010
@guan404ming thanks for the patch! I think we need to change encode() functions in benchmark files as well. And it would be better to check the tensor's shape. like, if it's 1D, use the single-sample encode path and then if it's 2D, use the batch encoding path and for anything else, throw a clear error explaining what shapes are supported. On the other hand , maybe we could support for pathlib.Path objects by using os.fspath() to convert them to strings before processing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
