rich7420 commented on code in PR #925:
URL: https://github.com/apache/mahout/pull/925#discussion_r2724267014


##########
testing/conftest.py:
##########
@@ -39,11 +41,6 @@
 except ImportError as e:
     _QDP_IMPORT_ERROR = str(e)
 
-# Skip qdp tests at collection time if dependencies are not available
-collect_ignore_glob = []
-if not _QDP_AVAILABLE:
-    collect_ignore_glob.append("qdp/*.py")
-

Review Comment:
   I think maybe qdp tests may fail at collection time on machines without 
PyTorch because collect_ignore_glob removal means testing/qdp modules still 
import torch at module load. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to