400Ping commented on code in PR #935: URL: https://github.com/apache/mahout/pull/935#discussion_r2742541389
########## qdp/qdp-core/src/dlpack.rs: ########## @@ -23,6 +23,7 @@ use std::sync::Arc; // DLPack C structures (matching dlpack/dlpack.h) #[repr(C)] +#[derive(Clone, Copy, Debug, Eq, PartialEq)] Review Comment: We need Eq/PartialEq for the device-type check in `extract_dlpack_tensor`, and Debug for error reporting and tests. Clone/Copy are kept for FFI ergonomics when passing `DLDevice` around. I added a short doc comment above the enum to document this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
