[ 
https://issues.apache.org/jira/browse/CONNECTORS-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682049#comment-13682049
 ] 

Karl Wright commented on CONNECTORS-710:
----------------------------------------

Thank you for the fix!

It is a good start, and better than before, but not quite what I meant.  It's a 
subtle point, but in dealing with repositories (and file systems!) there is 
race condition inherent in getting a version and then, later, processing a 
document.  It is standard practice to try to keep the document and the version 
consistent - and one way I've found to be able to do this is to actually put 
information into the version string in the getDocumentVersions() method, which 
is later retrieved and used during the processDocuments() method from the 
version string itself.

I'll propose a patch, since I think that will make it quite clear what I mean.

                
> FileConnector should have option of outputting a full http url, not just a 
> file:/ url
> -------------------------------------------------------------------------------------
>
>                 Key: CONNECTORS-710
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-710
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: File system connector
>    Affects Versions: ManifoldCF 1.3
>            Reporter: Minoru Osuka
>            Assignee: Minoru Osuka
>             Fix For: ManifoldCF 1.3
>
>         Attachments: Screen Shot 2013-06-11 at 5.46.55 PM.png
>
>
> I would like to enhance that FileConnector be able to convert from file path 
> to URI.
> FileOutputConnector will output the file path like Wget.
> $OUTPUT_PATH/http/localhost:8345/mcf-crawler-ui/showjobstatus.jsp
> I would like to enhance that FileConector be able to put documentIdentifere 
> like WebConnector.
> Current FileConnector can output id following,
> {code:xml}
> <str 
> name="id">file:/Users/minoru/tmp/out/http/localhost:8345/mcf-crawler-ui/showjobstatus.jsp</str>
> {code}
> Enhanced FileConnector can output id following,
> {code:xml}
> <str 
> name="id">file:/Users/minoru/tmp/out/http/localhost:8345/mcf-crawler-ui/showjobstatus.jsp</str>
> {code}
> or
> {code:xml}<str 
> name="id">http://localhost:8345/mcf-crawler-ui/showjobstatus.jsp</str></str>
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to