[
https://issues.apache.org/jira/browse/CONNECTORS-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13693348#comment-13693348
]
Karl Wright commented on CONNECTORS-727:
----------------------------------------
Hi,
Had a look at the revised code. Pretty much all seems good. Still, found a
couple of minor things:
1) This construct:
{code}
} finally {
EntityUtils.consume(response.getEntity());
method.releaseConnection();
}
{code}
... could just as easily do:
{code}
} finally {
method.abort();
}
{code}
I believe they are equivalent.
2) This is more significant. The XThreadStringBuffer method abandon():
{code}
public synchronized void abandon()
{code}
... is meant to be called in a finally block by the worker thread. If that's
not done, the background thread can get orphaned and exist forever. See
GoogleDrive connector for precise example.
Thanks!
Karl
> generic connector
> -----------------
>
> Key: CONNECTORS-727
> URL: https://issues.apache.org/jira/browse/CONNECTORS-727
> Project: ManifoldCF
> Issue Type: Improvement
> Reporter: Maciej Lizewski
> Assignee: Karl Wright
>
> OK, this is tricky, but really nice idea. I was thinking about indexing some
> sources which do not have API, or API does not provide information needed by
> Manifold, or there is dedicated system and IT team that can easily add some
> API.
> Now you have to write dedicated connector and probably some API extension,
> plugin, etc that would talk with each other to provide seeds, versions and
> documents. Which requires knowledge on how to write Manifold connectors AND
> knowledge about system - there is no so many programmers that know both
> systems :)
> So lets make things easier - provide "generic" Manifold connector that works
> with "generic" API (ie XML over HTTP which is *really* easy to implement in
> any language). This API and protocol are strictly defined and specified. Then
> to integrate with the custom document repository one has to only implement
> API entry point which follow those specifications.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
