[ 
https://issues.apache.org/jira/browse/CONNECTORS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13693861#comment-13693861
 ] 

Karl Wright edited comment on CONNECTORS-728 at 6/26/13 9:26 AM:
-----------------------------------------------------------------

Hi Osuka-san,

Actually, looking harder, I think you did understand my point, but missed one 
particular place which needs to be looked at.  Specifically:

{code}
        if (session.getFileSystem().exists(fileStatus.getPath())) {
{code}

This occurs twice; exists() throws IOException so I am pretty sure it should 
not be called lightly.  But perhaps there is another way to get the same 
information.  What happens, for instance, when you get the FileStatus of a 
deleted file?  Does it come back null?  If it does, just check fileStatus == 
null instead.

Actually, according to the docs online, this will throw FileNotFoundException 
if the path does not exist.  If you catch that specially from GetObject, you 
will know whether the file exists or not without needing to call exists().
                
      was (Author: [email protected]):
    Hi Osuka-san,

Actually, looking harder, I think you did understand my point, but missed one 
particular place which needs to be looked at.  Specifically:

{code}
        if (session.getFileSystem().exists(fileStatus.getPath())) {
{code}

This occurs twice; exists() throws IOException so I am pretty sure it should 
not be called lightly.  But perhaps there is another way to get the same 
information.  What happens, for instance, when you get the FileStatus of a 
deleted file?  Does it come back null?  If it does, just check fileStatus == 
null instead.

                  
> Add HDFS connector.
> -------------------
>
>                 Key: CONNECTORS-728
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-728
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: HDFS connector
>    Affects Versions: ManifoldCF 1.2
>            Reporter: Minoru Osuka
>            Assignee: Minoru Osuka
>            Priority: Minor
>             Fix For: ManifoldCF 1.3
>
>
> I would like to suggest you the HDFS Connector.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to