[
https://issues.apache.org/jira/browse/CONNECTORS-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866069#comment-13866069
]
Karl Wright commented on CONNECTORS-840:
----------------------------------------
Ok, after I redid parts of the IngestThread class to make things final that
should be final, we now have this error:
{code}
compile-tests:
[mkdir] Created dir: C:\wip\mcf\CONNECTORS-840\connectors\solr\build\connect
or-tests\classes
[javac] C:\wip\mcf\CONNECTORS-840\connectors\connector-build.xml:462:
warning: 'includeantruntime' was not set, defaulting to
build.sysclasspath=last; set to false for repeatable builds
[javac] Compiling 3 source files to
C:\wip\mcf\CONNECTORS-840\connectors\solr\build\connector-tests\classes
[javac] warning: [options] bootstrap class path not set in conjunction with
-source 1.6
[javac]
C:\wip\mcf\CONNECTORS-840\connectors\solr\connector\src\test\java\org\apache\manifoldcf\agents\output\solr\IngestThreadTest.java:123:
error: cannot find symbol
[javac] ingestThreadToTest.setKeepAllMetadata( keep );
[javac] ^
[javac] symbol: method setKeepAllMetadata(Boolean)
[javac] location: variable ingestThreadToTest of type
HttpPoster.IngestThread
[javac] Note:
C:\wip\mcf\CONNECTORS-840\connectors\solr\connector\src\test\java\org\apache\manifoldcf\agents\output\solr\SolrConnectorTest.java
uses unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] 1 error
[javac] 1 warning
{code}
If you can find another way to write this test so that we can keep the "final"
modifiers for the thread, please submit a patch to that effect. I am out of
time for tonight.
> Job - Solr Mapping Improvement
> ------------------------------
>
> Key: CONNECTORS-840
> URL: https://issues.apache.org/jira/browse/CONNECTORS-840
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Lucene/SOLR connector
> Affects Versions: ManifoldCF 1.4.1
> Reporter: Alessandro Benedetti
> Assignee: Karl Wright
> Priority: Minor
> Labels: field, mapping, request, solr, update
> Fix For: ManifoldCF 1.5
>
> Attachments: CONNECTORS-840.patch
>
>
> "When you configure a job to use a Solr-type output connection, the Solr
> connection type provides a tab called "Field Mapping". The purpose of this
> tab is to allow you to map metadata fields as fetched by the job's connection
> type to fields that Solr is set up to receive. This is necessary because the
> names of the metadata items are often determined by the repository, with no
> alignment to fields defined in the Solr schema. You may also suppress
> specific metadata items from being sent to the index using this tab.
> Add a new mapping by filling in the "source" with the name of the metadata
> item from the repository, and "target" as the name of the output field in
> Solr, and click the "Add" button. Leaving the "target" field blank will
> result in all metadata items of that name not being sent to Solr."
> In my opinion we should change the way a metadata field is suppressed.
> The most natural way is that we express only the mappings of the metadata
> fields we want to keep.
> All the missing params will not be sent to Solr.
> The improvement will be :
> - same interface with a boolean flag in addition, this flag will specify if
> the missing metadata fields not expressed should be sent to Solr with the
> original names or not sent at all.
> In this way if we want to keep 3/100 metadata fields, we don't have to write
> 100 mapping entries , 97 empty but simply 3 entries and activate the flag.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)