[
https://issues.apache.org/jira/browse/CONNECTORS-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990866#comment-13990866
]
Karl Wright commented on CONNECTORS-916:
----------------------------------------
Hi Takumi.
I looked briefly at this new patch. It's a little confusing and I'd like to
clean it up before committing to the branch. But can you explain why you
changed the error handling again? Specifically, I mean this:
{code}
catch (SAXException e) {
- // if document data could not be converted to JSON by jackson.
- throw new ManifoldCFException(e);
+ // if document data could not be converted to JSON by jackson.
+ Logging.connectors.debug(e);
+ return DOCUMENTSTATUS_REJECTED;
} catch (JsonProcessingException e) {
- // if document data could not be converted to JSON by jackson.
- throw new ManifoldCFException(e);
+ // if document data could not be converted to JSON by jackson.
+ Logging.connectors.debug(e);
+ return DOCUMENTSTATUS_REJECTED;
} catch (TikaException e) {
- // if document could not be parsed by tika.
+ // if document could not be parsed by tika.
+ Logging.connectors.debug(e);
return DOCUMENTSTATUS_REJECTED;
} catch (IOException e) {
- // if document data could not be read when the document parsing by tika.
- throw new ManifoldCFException(e);
+ // if document data could not be read when the document parsing by tika.
+ Logging.connectors.debug(e);
+ return DOCUMENTSTATUS_REJECTED;
}
{code}
> Amazon CloudSearch output connector
> -----------------------------------
>
> Key: CONNECTORS-916
> URL: https://issues.apache.org/jira/browse/CONNECTORS-916
> Project: ManifoldCF
> Issue Type: New Feature
> Components: Amazon CloudSearch output connector
> Affects Versions: ManifoldCF 1.7
> Reporter: Takumi Yoshida
> Assignee: Karl Wright
> Fix For: ManifoldCF 1.7
>
> Attachments: 0507.diff, 1.patch, 2.diff, 3.diff,
> exception_handling.diff, exception_handling_2.diff
>
>
> I wrote some codes snipetts of output connector for Amazon CloudSearch.
> I would like you to review my code. You can crawl web site and feed HTML page
> to Amazon CloudSearch.
> but it is not perfectly completed followoing reason.
> - does not write any codes for configuration page.
> - supporting file type is only HTML
> Thank you for your time,
> Takumi Yoshida
--
This message was sent by Atlassian JIRA
(v6.2#6252)
