[
https://issues.apache.org/jira/browse/CONNECTORS-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358083#comment-14358083
]
Karl Wright edited comment on CONNECTORS-1160 at 3/12/15 4:34 AM:
------------------------------------------------------------------
Hi Kishore,
I've reviewed this. It looks really good, actually.
If you've given the UI a thorough exercise, and you've hand-tested everything
to be sure it works as it did before, I think this can be committed to trunk.
(I notice there are a few missing translations, but I believe that those were
already there before this project was started. We can tackle those in a
separate ticket.)
The other thing I want to be sure of is that there are no functional changes
included in this reorganization. I believe you had mentioned one such change
earlier, but due to the volume of code involved it's not easy to determine
whether or not that was included. I would prefer greatly to keep
reorganizations separate from functional changes, if possible.
Please let me know if/when you are satisfied that this is ready to be
committed. Thanks again!
was (Author: [email protected]):
Hi Kishore,
I've reviewed this. It looks really good, actually.
If you've given the UI a thorough exercise, and you've hand-tested everything
to be sure it works as it did before, I think this can be committed to trunk.
(I notice there are a few missing translations, but I believe that those were
already there before this project was started. We can tackle those in a
separate ticket.)
Please let me know if/when you are satisfied that this is ready to be
committed. Thanks again!
> Update Livelink Connector HTML String to Velocity Template
> ----------------------------------------------------------
>
> Key: CONNECTORS-1160
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1160
> Project: ManifoldCF
> Issue Type: Improvement
> Components: LiveLink connector
> Affects Versions: ManifoldCF 2.0.1
> Reporter: Kishore Kumar
> Assignee: Karl Wright
> Priority: Minor
> Labels: connector, patch, velocity
> Fix For: ManifoldCF 1.9, ManifoldCF 2.1
>
> Attachments: CONNECTORS-1160-2.patch, CONNECTORS-1160.patch
>
> Original Estimate: 672h
> Remaining Estimate: 672h
>
> Hi [[email protected]]
> I would like to contribute to Livelink connector by replacing all stringified
> html into velocity templates, if you think that is possible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
