Hi, I am sorry, I could not answered before because I have been busy.
Thanks Rafa for checking the Nuxeo Connector. I see you saw some code to fix and improve. I am totally available to help you if you consider it apropriate. Thanks all, regards. On 23 November 2016 at 19:12, Rafa Haro <[email protected]> wrote: > Hi Karl, > > checking again the client, Nuxeo artifacts are only scoped for test, so I'm > my opinion we are fine > > On Wed, Nov 23, 2016 at 6:53 PM Karl Wright <[email protected]> wrote: > > > Hi Rafa, > > > > We can't ship any LGPL-licensed jars, so a connector that requires them > > will have to be considered "proprietary", and structured much like the > > jcifs connector. > > > > You would also need to be sure there aren't any client library > dependencies > > that have an incompatible license with Apache. > > > > Thanks, > > Karl > > > > > > On Wed, Nov 23, 2016 at 12:45 PM, Rafa Haro <[email protected]> wrote: > > > > > Nuxeo artifacts seems to be LGPL 2 > > > > > > On Wed, Nov 23, 2016 at 6:40 PM Rafa Haro <[email protected]> wrote: > > > > > > > Hi Karl, > > > > > > > > I have confirmed that currently only Nuxeo Documents' properties are > > > being > > > > indexed, the content is not being fetched at all. Actually, the Nuxeo > > > REST > > > > API, logically, only returns properties. The content must be fetched > > > using > > > > Nuxeo Automation Services. > > > > > > > > Nuxeo is currently providing a Java Client that basically covers both > > > > backends (REST and Automation) into a single client library. It > would > > be > > > > much more easier to implement the connector using it. The code is > here: > > > > > > > > https://github.com/nuxeo/nuxeo-java-client > > > > > > > > According to pom file, the license is GNU LESSER GENERAL PUBLIC > > LICENSE, > > > > Version 2.1. I'm not sure about compatibility and probably we would > > need > > > > to check also third-party dependencies, but in my opinion it is worth > > it. > > > > > > > > What do you think? > > > > > > > > On Wed, Nov 23, 2016 at 3:41 PM Rafa Haro <[email protected]> wrote: > > > > > > > > Ok, > > > > > > > > First quick review: the connector needs a major refactoring, mainly > for > > > > modeling Nuxeo REST responses (JSON) properly into metadata maps and > > the > > > > content stream. I will try to dedicate sometime this week > > > > > > > > > > > > On Wed, Nov 23, 2016 at 12:58 PM Rafa Haro <[email protected]> wrote: > > > > > > > > Bullets 1 and 2 are on me > > > > > > > > On Wed, Nov 23, 2016 at 12:56 PM Karl Wright <[email protected]> > > wrote: > > > > > > > > Tests pass too now. > > > > > > > > I had to also add Apache headers to everything, and change tabs to > > > spaces. > > > > > > > > I think the final step for this connector, before being merged to > > trunk, > > > is > > > > to audit the code for the following issues: > > > > - memory boundedness - does it ever load a document 100% into memory? > > or > > > > does it stream? If it loads documents into memory there has to be a > > good > > > > reason, and there has to be a way of preventing large documents from > > > > blowing up ManifoldCF. Usually that's a document size limit. > > > > - error handling - does it throw appropriate ServiceInterruptions > when > > > > stuff goes wrong? > > > > - interruptibility - is it structured so that crawling threads don't > > wind > > > > up waiting indefinitely on sockets? > > > > > > > > We really need to address the first and second problems before going > > > ahead > > > > with this, but the third can be postponed. > > > > > > > > Rafa, what's your take? > > > > > > > > Thanks, > > > > Karl > > > > > > > > - > > > > > > > > On Tue, Nov 22, 2016 at 7:57 PM, Karl Wright <[email protected]> > > wrote: > > > > > > > > > Actually, I committed it and it ant builds now. I'll try to get > the > > > > tests > > > > > running tomorrow. > > > > > > > > > > Karl > > > > > > > > > > > > > > > On Tue, Nov 22, 2016 at 7:12 PM, Karl Wright <[email protected]> > > > wrote: > > > > > > > > > >> Thanks!! > > > > >> > > > > >> I may have some time to look at this tomorrow. > > > > >> > > > > >> Karl > > > > >> > > > > >> > > > > >> On Tue, Nov 22, 2016 at 6:21 PM, Rafa Haro <[email protected]> > > wrote: > > > > >> > > > > >>> Hi Devs, > > > > >>> > > > > >>> I have imported the Nuxeo Connector from the Github Repository > > > > directly > > > > >>> to > > > > >>> ManifoldCF's connectors folder at the following branch: > > > > >>> > > http://svn.apache.org/repos/asf/manifoldcf/branches/CONNECTORS-1290/ > > > > >>> > > > > >>> I have simply included the code (updating its parent artifact to > > > > >>> mcf-connectors 2.6-SNAPSHOT) and updated the parent modules > list. I > > > > have > > > > >>> tried to build the branch also but got test failures on Pull > Agent > > > > module > > > > >>> > > > > >>> Ant building is missing for this connector, so that should > probably > > > the > > > > >>> first thing to tackle now > > > > >>> > > > > >>> Cheers, > > > > >>> Rafa > > > > >>> > > > > >>> On Mon, Nov 21, 2016 at 4:55 PM Rafa Haro <[email protected]> > > wrote: > > > > >>> > > > > >>> > ok ok guys.....sorry for that.... I PROMISE to do it > > > tomorrow.....man > > > > >>> word > > > > >>> > > > > > >>> > > > > > >>> > > > > > >>> > On Mon, Nov 21, 2016 at 4:45 PM Piergiorgio Lucidi < > > > > >>> [email protected]> > > > > >>> > wrote: > > > > >>> > > > > > >>> > Hi Karl, > > > > >>> > > > > > >>> > thank you for your message. > > > > >>> > > > > > >>> > Go Rafa go!!! > > > > >>> > ^__^ > > > > >>> > > > > > >>> > Probably the next week I should have some time to spend on > > updating > > > > the > > > > >>> > documentation. > > > > >>> > > > > > >>> > Piergiorgio > > > > >>> > > > > > >>> > 2016-11-21 16:39 GMT+01:00 Karl Wright <[email protected]>: > > > > >>> > > > > > >>> > > Hi all, > > > > >>> > > > > > > >>> > > We're scheduled to release MCF 2.6 by the end of the year, so > > I'd > > > > >>> like to > > > > >>> > > close down features for this release by the middle of > December. > > > > This > > > > >>> > gives > > > > >>> > > us three weeks to pull it together. > > > > >>> > > > > > > >>> > > The release is quite light on new features at the moment. > > > There's > > > > >>> > > apparently going to be a new notification connector put in > > place > > > by > > > > >>> end > > > > >>> > of > > > > >>> > > next week, and the Nuxeo connector developed during the > Google > > > > >>> Summer of > > > > >>> > > Code is also hopefully going to be in there. Without those > two > > > we > > > > >>> really > > > > >>> > > only have a relatively small number of fixes and upgrades and > > > > that's > > > > >>> it. > > > > >>> > > > > > > >>> > > So let's encourage Rafa to get that connector landed on an > SVN > > > > >>> branch so > > > > >>> > we > > > > >>> > > can look at it and get everything together! :-) > > > > >>> > > > > > > >>> > > Thanks, > > > > >>> > > Karl > > > > >>> > > > > > > >>> > > > > > >>> > > > > > >>> > > > > > >>> > -- > > > > >>> > Piergiorgio Lucidi > > > > >>> > Technology Evangelist @ Sourcesense > > > > >>> > Author and Technical Reviewer @ Packt Publishing > > > > >>> > Mentor / PMC Member / Committer @ Apache Software Foundation > > > > >>> > Community Star / Wiki Gardener / Forum Moderator / Certified > > > > >>> Instructor, > > > > >>> > Engineer and Administrator @ Alfresco > > > > >>> > Top Community Contributor @ Crafter > > > > >>> > Project Leader / Committer @ JBoss > > > > >>> > http://www.open4dev.com > > > > >>> > > > > > >>> > > > > > >>> > > > > >> > > > > >> > > > > > > > > > > > > > > > > > > > -- David Arroyo Escobar
