Right. The issue is that the unit tests rely on embedding an elasticsearch
instance which is officially deprecated:
https://www.elastic.co/blog/elasticsearch-the-server
There are integration methods using ESIntegTestCase. I'm looking if we can
quickly refactor to utilize that or the unit tests are going to need to be
written.
The code is more or less fine for what I can see.
On 4/18/20, 8:22 AM, "Furkan KAMACI" <furkankam...@gmail.com> wrote:
Hi,
There is a compatibility matrix for Elasticsearch. We need to support at
least Elasticsearch 6.5.x for Java 11 support. You can check it from here:
https://www.elastic.co/de/support/matrix#matrix_jvm
@Cihad
As far as I know, current support is not 2.0.0. It is 5.5.2:
https://github.com/apache/manifoldcf-integration-elasticsearch-5.5
@Karl Wright <daddy...@gmail.com>
So, such an upgrade from 5.5.2 to 6.5.x may not be so painful. Committers
who use ES can comment on this.
My comments:
+1 to temporarily turning those tests off
-1 to temporarily turning the connector off
Kind Regards,
Furkan KAMACI
On Sat, Apr 18, 2020 at 3:27 PM Cihad Guzel <cguz...@gmail.com> wrote:
> Hi Karl,
>
> MFC ES Connector uses the Elastic Search 2.0.0 . It's an ancient version.
> The latest version is 7.6.2 . So, I agree with you and I think we can
> temporarily turn the connector off.
>
> +1
>
> Kind Regards,
> Cihad Güzel
>
>
> Karl Wright <daddy...@gmail.com>, 18 Nis 2020 Cmt, 11:41 tarihinde şunu
> yazdı:
>
> > Hi all,
> >
> > We're due to release ManifoldCF 2.16 by April 30th. The major work for
> > this release was adoption of Java 11, and that work is incomplete
because
> > of ElasticSearch incompatibilities. I'm therefore tempted to hold the
> > release until we at least have a plan for dealing with ES going forward.
> >
> > It's not clear that our ES connector support is affected, but certainly
> our
> > integration tests are, because Java 11 isn't supported in any of the ES
> > versions we run for those tests. So at the least we need to decide to
> turn
> > those off. And indeed, we really need to have someone with ES
experience
> > map a strategy for getting our ES support back into compliance with
> what's
> > out in the world at large now. Cihad Guzel did much work on Java 11 but
> > stumbled over the Elastic Search problem. Any of our committers who
know
> > ES and are stuck inside at the moment, please speak up.
> >
> > Thanks in advance,
> > Karl
> >
>
