[
https://issues.apache.org/jira/browse/CONNECTORS-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461555#comment-17461555
]
Markus Schuch edited comment on CONNECTORS-1680 at 12/17/21, 4:44 PM:
----------------------------------------------------------------------
I think this is actually causes the issue:
{quote}
I also looked over the code changes. One minor issue: the assignment of
{{baseDocumentIdentifier}} in the constructor of {{ProcessActivityLinkHandler}}
looks useless (assigned to itself) -->
[https://github.com/apache/manifoldcf/commit/8b88d6d44aba54ee276619340ad36a9cc441932d#diff-9fff09bc306de2115d24403a5fe1c3c9fe831d30a54448291f1f90b4d5c6b2a7R3889]
{quote}
This should be the fix, right?
{code:java}
this.baseDocumentIdentifier = documentIdentifier;
{code}
was (Author: schuchm):
I think this is actually causes the issue:
{quote}I also looked over the code changes. One minor issue: the assignment of
{{baseDocumentIdentifier}} in the constructor of {{ProcessActivityLinkHandler}}
looks useless (assigned to itself) -->
[https://github.com/apache/manifoldcf/commit/8b88d6d44aba54ee276619340ad36a9cc441932d#diff-9fff09bc306de2115d24403a5fe1c3c9fe831d30a54448291f1f90b4d5c6b2a7R3889]
{quote}
This should be the fix, right?
{code:java}
this.baseDocumentIdentifier = documentIdentifier;
{code}
> WebConnector: Support the Document Base URL element
> ---------------------------------------------------
>
> Key: CONNECTORS-1680
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1680
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Web connector
> Reporter: Markus Schuch
> Assignee: Karl Wright
> Priority: Major
> Fix For: ManifoldCF 2.21
>
>
> HTML allows to specifiy the base URL to use for all relative URLs in a
> document:
> {code:java}
> <!doctype html>
> <html lang="de">
> <head>
> <base href="https://example.org/"/>
> ...
> </head>
> ...
> </html>{code}
> [https://developer.mozilla.org/de/docs/Web/HTML/Element/base]
> The Web Connector should respect this element when handling relative links.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
