Hi Karl,

Thanks for your email. About this compile error, I think there are two
ways to fix it.

1. Change jetty.version within build.xml and pom.xml to
9.4.48.v20220622 same as CONNECTORS-1740 branch:

build.xml
- <property name="jetty.version" value="9.4.25.v20191220"/>
+ <property name="jetty.version" value="9.4.48.v20220622"/>

pom.xml
- <jetty.version>9.4.25.v20191220</jetty.version>
+ <jetty.version>9.4.48.v20220622</jetty.version>

2. Change the parameters of the HttpClient function within
ModifiedHttp2SolrClient.java as below:

- httpClient = sslEnabled ? new HttpClient(transport,
sslContextFactory) : new HttpClient(transport);
+ httpClient = sslEnabled ? new HttpClient(transport,
sslContextFactory) : new HttpClient(transport, null);

The reason for this fix is that the constructor
HttpClient(HttpClientTransport) does not exist in older jetty.version
like 9.4.25.v20191220, so it seems that trying to use the constructor
HttpClient(SslContextFactory) caused a conversion error.

https://www.javadoc.io/doc/org.eclipse.jetty/jetty-project/9.4.25.v20191220/org/eclipse/jetty/client/HttpClient.html#%3Cinit%3E(org.eclipse.jetty.client.HttpClientTransport,org.eclipse.jetty.util.ssl.SslContextFactory)

Best Regards,
Mingchun

2023年6月6日(火) 10:03 Karl Wright <daddy...@gmail.com>:
>
> Hi Mingchun,
>
> The previous work done on this branch is almost complete but there is still
> a build error I get:
>
>     [javac]
> C:\wip\mcf\trunk\connectors\solr\connector\src\main\java\org\apache\manifoldcf\agents\output\solr\ModifiedHttp2SolrClient.java:200:
> error: incompatible types: HttpClientTransport cannot be converted to
> SslContextFactory
>     [javac]       httpClient = sslEnabled ? new HttpClient(transport,
> sslContextFactory) : new HttpClient(transport);
>     [javac]
>                                ^
>
> This didn't show up until I merged the branch onto trunk.  I haven't yet
> committed it because it doesn't quite build.  Any idea how to resolve this?
>
> Karl

Reply via email to