[ 
https://issues.apache.org/jira/browse/CONNECTORS-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18064491#comment-18064491
 ] 

Piergiorgio Lucidi commented on CONNECTORS-1773:
------------------------------------------------

Here are the changes for this improvements that I'm trying to test:

PipelineConnections.java:
 * Updated the constructor, it now uses a List to preserve all transformation 
stages, even if they use the same connection.
 * Mapped each pipeline stage index to its corresponding index in the 
non-unique-ified list of transformation connections.
 * This ensures that getTransformationConnectionNames() and 
getTransformationConnections() now return an entry for every stage, allowing 
the framework to request multiple connector instances.


IncrementalIngester.java:
 * Updated the pipelineGrabWithVersions and pipelineGrab methods to generate 
unique ordering keys for the grabMultiple call.
 * The unique keys are generated by appending the array index to the connection 
name (e.g., ConnectionA-0, ConnectionA-1).
 * This satisfies the uniqueness requirement of ConnectorPool.grabMultiple 
while maintaining a consistent acquisition order across different threads and 
jobs, thus avoiding deadlocks.
 * This change ensures that each stage in the pipeline receives its own 
dedicated connector instance from the pool.

> Bug in Manifoldcf UI when 2 same connectors are in the pipeline
> ---------------------------------------------------------------
>
>                 Key: CONNECTORS-1773
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-1773
>             Project: ManifoldCF
>          Issue Type: Bug
>            Reporter: Guylaine Bassette
>            Assignee: Piergiorgio Lucidi
>            Priority: Major
>             Fix For: ManifoldCF 2.30
>
>
> Hello,
> If I want to add the same transformation connector 2 times at 2 different 
> steps in a job's pipeline, I get a bug in the interface. When I click on the 
> tab of one, the other is also selected, so that if I want to switch to the 
> other, I can't. The explanation is that the code generated in the HTML for 
> the tags is as follows:
> {code:java}
> <div class="btn-group" sequencenumber="4">                        
>     <a class="btn btn-md active" href="#tab_13" alt="Regex Entity tab">Regex 
> Entity</a>
> </div>
> <div class="btn-group" sequencenumber="5">                        
>     <a class="btn btn-md " href="#tab_14" alt="Tika server tab" 
> onclick="javascript:SelectSequencedTab("Tika server","4");return false;">Tika 
> server</a>
> </div>
> <div class="btn-group" sequencenumber="6">                                    
>      
> <!-- Here I should have: onclick="javascript:SelectSequencedTab... -->
>    <a class="btn btn-md active" href="#tab_15" alt="Regex Entity tab">Regex 
> Entity</a>
> </div>
> {code}
>  
> If I click on the "Tika" tab, I have this:
>  
> {code:java}
> <div class="btn-group" sequencenumber="4">                        
>     <a class="btn btn-md " href="#tab_13" alt="Regex Entity tab" 
> onclick="javascript:SelectSequencedTab("Regex Entity","3");return 
> false;">Regex Entity</a>
> </div>
> <div class="btn-group" sequencenumber="5">                        
>     <a class="btn btn-md active" href="#tab_14" alt="Tika server tab">Tika 
> server</a>
> </div>
> <div class="btn-group" sequencenumber="6">                        
>     <a class="btn btn-md " href="#tab_15" alt="Regex Entity tab" 
> onclick="javascript:SelectSequencedTab("Regex Entity","5");return 
> false;">Regex Entity</a>
> </div>
> {code}
> It's the right behavior, so I don't feel that the error comes from my 
> definition of my transformation connector... And I experience the same for 
> other existing transformation connectors.
> Should the title of the 2nd tab be different? In my opinion, this would be a 
> bug, as the sequence num is there to make the distinction.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to