Hello, Thanks for the review. I have made the changes and uploaded the Proposal document to Melange. Please, review and Suggest modifications if any. Thanks.
On Wed, Mar 19, 2014 at 12:41 AM, Sergio Fernández <[email protected]>wrote: > Dear Sushant makode, > > * To what respect the target code base, I don't understand what criteria > you have used to select the modules you listed. What I could expect is that > marmotta-security would be extended, or mayb e a new marmotta-oauth2 > module, to support OAuth2-based authorization, which in the end means > supporting suc workflow from the admin interface and extend the current > access control filter. And probably also extend the modules with relevant > web services: marmotta-core, marmotta-sparql, marmotta-ldp, etc. > > * Before the step 3 of your flow, I'd add authentication in marmotta if > required. > > * From my understanding, additional endpoints would be only required for > some functional purposes (authorization request, authorization grant, and > access tokens exchange, refresh and revocation). Resources authorization > should be done in the current filter, so I do not understand the first use > case. > > * We would expect the OAuth2 support could be enabled/disabled by > configuration. > > * Marmotta uses Resteasy as JAX-RS implementation, so its OAuth2 support > should be taken intro account before exploring external alternatives: > http://docs.jboss.org/resteasy/docs/3.0.6.Final/userguide/html/oauth2.html > > * The working plan sounds good for me. > > Please, submit your proposal to Melange once you've addressed these issues. > > Thanks for your proposal, and welcome to Marmotta. > > Cheers, > > > On 18/03/14 08:49, Sushant makode wrote: > >> Hi, >> I had attached it as a PDF. >> I have attached a doc version with this mail. >> Thanks. >> Sorry for the confusion. >> >> >> On Tue, Mar 18, 2014 at 12:48 PM, Sergio Fernández < >> [email protected]> wrote: >> >> I think you forgot to attach or link your draft ;-) >>> >>> >>> On 17/03/14 21:50, Sushant makode wrote: >>> >>> Hi, >>>> This is my basic understanding of Oauth2 support for Marmotta. >>>> https://issues.apache.org/jira/browse/MARMOTTA-432 >>>> >>>> Please review the document attached with this mail and let me know your >>>> valuable suggestions and the points were I may have mistaken >>>> >>>> Thanks. >>>> >>>> >>>> -- >>> Sergio Fernández >>> Senior Researcher >>> Knowledge and Media Technologies >>> Salzburg Research Forschungsgesellschaft mbH >>> Jakob-Haringer-Straße 5/3 | 5020 Salzburg, Austria >>> T: +43 662 2288 318 | M: +43 660 2747 925 >>> [email protected] >>> http://www.salzburgresearch.at >>> >>> >> >> >> > -- > Sergio Fernández > Senior Researcher > Knowledge and Media Technologies > Salzburg Research Forschungsgesellschaft mbH > Jakob-Haringer-Straße 5/3 | 5020 Salzburg, Austria > T: +43 662 2288 318 | M: +43 660 2747 925 > [email protected] > http://www.salzburgresearch.at > -- Thanks And Regards, Sushantkumar Makode M. Tech. CSE IIIT Hyderabad +91 9505204814
