[ 
https://issues.apache.org/jira/browse/MARMOTTA-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532225#comment-14532225
 ] 

Jakob Frank commented on MARMOTTA-611:
--------------------------------------

Hi [~schlegel],

thanks for the PR - I had a quick look into the code, here some comments:

* You added getters only for some of the Selectors, is there a specific reason 
for your selection? Why not for all Selectors?
* The javadoc for some of the getters is simply wrong, probably copy-pase? 
(e.g. IntersectionSelector)
* You only added access methods for selectors: What about other fields? (e.g. 
in the FunctionSelector the NodeFunction)


> Allow access to child NodeSelectors in NodeSelectors
> ----------------------------------------------------
>
>                 Key: MARMOTTA-611
>                 URL: https://issues.apache.org/jira/browse/MARMOTTA-611
>             Project: Marmotta
>          Issue Type: Wish
>          Components: LDPath
>    Affects Versions: 3.3.0
>            Reporter: Kai Schlegel
>
> We would like to directly access child NodeSelectors in NodeSelector 
> instances (e.g. left and right NodeSelector in a PathSelector instance).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to