If someone is working in the SPARQL code then it would be really nice to fix https://issues.apache.org/jira/browse/MARMOTTA-651
- this is still a showstopper for me using marmotta in my projects Rob Atkinson On Mon, 10 Apr 2017 at 09:26 gmora1223 <[email protected]> wrote: > GitHub user gmora1223 opened a pull request: > > https://github.com/apache/marmotta/pull/27 > > Solved MARMOTTA-657 - SPARQL query GROUP BY with ORDER BY clause fails. > > When building a SQL query, GROUP BY statements allow aggregate > functions. This was solved comparing if an statement from ORDER BY is not > an aggregate funtion, then add if not continue. This PR solves MARMOTTA-657. > > Be sure to do all of the following to help us incorporate your > contribution quickly and easily: > > - [x] Make sure the PR title is formatted like: `MARMOTTA-XXX: title > of pull request` > (replace `XXX` in the title with the actual Jira issue number; if > there is no one, > please [create one](https://issues.apache.org/jira/browse/MARMOTTA) > before). > - [x] Make sure tests pass via mvn clean verify (even better, enable > Travis-CI on your > fork and ensure the whole test suite passes). > - [ ] If this contribution is large, please file an > [Apache's Individual Contributor License Agreement]( > https://www.apache.org/licenses/icla.txt). > > --- > > > > You can merge this pull request into a Git repository by running: > > $ git pull https://github.com/gmora1223/marmotta MARMOTTA-657 > > Alternatively you can review and apply these changes as the patch at: > > https://github.com/apache/marmotta/pull/27.patch > > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > > This closes #27 > > ---- > commit 9abcdd92f3e1615bf7c98540ecc2d9d776313f73 > Author: gmora1223 <[email protected]> > Date: 2017-04-09T22:44:17Z > > Solved MARMOTTA-657 - SPARQL query GROUP BY with ORDER BY clause fails. > > When building a SQL query, GROUP BY statements allow aggregate > functions. This was solved comparing if an statement from ORDER BY is not > an aggregate funtion, then add if not continue. > > Signed-off-by: Gustavo Mora <[email protected]> > > ---- > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at [email protected] or file a JIRA ticket > with INFRA. > --- >
