On 13/03/13 18:56, Sergio Fernández wrote:
Hi Andy,
On 13/03/13 18:20, Andy Seaborne wrote:
Build one and we can review it. It's easier to refer to a concrete thing.
Sebastian created a full release building based on Maven. OK, tomorrow
we'll deploy one releasing to dist.apache.org/repos/dist/dev/marmotta
While we're checking, and it'll take a while, putting the source-release
on people.a.o/~user is fine.
If there is a source-release file I didn't find it.
You'll need to explain the build as well - I see a lot of modules, and
don't know where to look for things like war files that roll up recursively.
It is likely the N&L that go at the top of the source code tree is
different to the N&L at the top of the distribution.
Yes, this is automatically handled by the Maven task that Sebastian wrote.
Strange - I can find only one NOTICE and one LICENSE file in the whole
of the source code tree.
I can not find any DEPENDENCIES files in the code tree. Marmotta is
sufficiently big that default autogeneration is unlikely to be accurate.
Listing every single Sesame module is heavy :-) One mention is enough.
'an unknown organization' is a bit vague :-)
(Google guava)
Even Apache products need some checking: e.g. HttpComponents core:
https://svn.apache.org/repos/asf/httpcomponents/httpcore/trunk/NOTICE.txt
says :
"""
This project contains annotations derived from JCIP-ANNOTATIONS
Copyright (c) 2005 Brian Goetz and Tim Peierls. See http://www.jcip.net
"""
so if you reship HttpComponents core, you'll need that text somewhere.
If you just link to it, you don't.
[[
The module marmotta-webapp packages together all dependencies, including
transitive ones. For copyright details please refer to the dependencies
declared at build configuration files.
]]
You need to pull out the transitive ones for N&L for the binary here.
On each binary distribution, right? Yes, this is managed by Maven on the
building process.
Don't forget to put the appropriate N&L in the jar files under META_INF.
Under control, yes.
Not as easy as that :-)
I looked in a couple (eg. marmotta-core...jar, sesame-tools-rio-api) and
all I see is an autogenerated NOTICE and LICENSE so unless that jar had
no source code N&L issues, it's unlike the automatically generated ones
are enough - they don't manage the source code needs.
The NOTICE.txt and LICENSE.txt from the top could be used for the
META-INF or you can have per-module ones.
Autogeneration can also lead to bad text:
"""
Sesame I/O: API
Copyright 2013 The Apache Software Foundation
"""
does not say "Apache Marmotta"
Andy
Sorry it's rushed ....
Something that needs to be done ;-)
Believe me, we really appreciate your kind support on this process :-)
Cheers,
