Fixed for Cactus and Checkstyle. Thanks -Vincent
> -----Original Message----- > From: Florin Vancea [mailto:[EMAIL PROTECTED] > Sent: 05 June 2003 07:24 > To: Maven Developers List > Subject: Re: cvs commit: maven/src/plugins-build/checkstyle plugin.jelly > > P.S.: I did a quick search for 'include name="${' in the sources and I > suspect the same issue also appears in the following plugins: > > cactus, ejb, jalopy, war, > > eventually with different potential of getting transformed into a > significant bug. Usually these properties are left untouched by the > "end-users" and that's why this did not show up until now. > > Florin. > > > ----- Original Message ----- > From: "Florin Vancea" <[EMAIL PROTECTED]> > To: "Maven Developers List" <[EMAIL PROTECTED]> > Sent: Thursday, June 05, 2003 8:09 AM > Subject: Re: cvs commit: maven/src/plugins-build/checkstyle plugin.jelly > > > > Vincent, I think you missed what Thomas really meant, and catched > another > > bug (actually a typo). > > > > The <ant:include ...> element may have in the name attribute _just_one_ > > pattern, therefore if the property contains several patterns, as the > > property name suggests, then something will go wrong. > > > > Thomas suggested to use instead the attributes of the <fileset..> > element > > (i.e. "includes" and "excludes"), which support comma or space delimited > > pattern sets. > > > > Florin > > > > ----- Original Message ----- > > From: <[EMAIL PROTECTED]> > > To: <[EMAIL PROTECTED]> > > Sent: Wednesday, June 04, 2003 10:23 PM > > Subject: cvs commit: maven/src/plugins-build/checkstyle plugin.jelly > > > > > > > vmassol 2003/06/04 12:23:03 > > > > > > Modified: src/plugins-build/checkstyle plugin.jelly > > > Log: > > > Fixed "exclude" bug. Thanks to Thomas Diesler. > > > > > > Revision Changes Path > > > 1.7 +1 -1 maven/src/plugins-build/checkstyle/plugin.jelly > > > > > > Index: plugin.jelly > > > =================================================================== > > > RCS file: /home/cvs/maven/src/plugins- > build/checkstyle/plugin.jelly,v > > > retrieving revision 1.6 > > > retrieving revision 1.7 > > > diff -u -r1.6 -r1.7 > > > --- plugin.jelly 30 May 2003 13:13:25 -0000 1.6 > > > +++ plugin.jelly 4 Jun 2003 19:23:03 -0000 1.7 > > > @@ -130,7 +130,7 @@ > > > > > > <ant:fileset dir="${pom.build.sourceDirectory}"> > > > <ant:include name="${maven.checkstyle.includes}"/> > > > - <ant:include name="${maven.checkstyle.excludes}"/> > > > + <ant:exclude name="${maven.checkstyle.excludes}"/> > > > </ant:fileset> > > > > > > <ant:formatter type="xml" > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
