> -----Original Message-----
> From: Michal Maczka [mailto:[EMAIL PROTECTED]
> Sent: 18 June 2003 10:01
> To: 'Maven Developers List'
> Subject: RE: Recent changes in war plugin
> 
> Yes.
> I am still working on deployer.
> That's the art which I want to use in this plugin to add missing
> functionality.
> 
> Once I am readay with this for war plugin, I am planning to change
also
> other plugins.
> 
> 
> Last time I am asking:
> 
> Does anybody has something against building war ___always__ in two
> distinct
> steps?

I don't think I like it. At least I would like to keep using the Ant war
task which does a lot of things your implementation will not be doing
right away. And we will benefit from any improvement to Ant war task.

So I'm -1 to drop usage of the Ant war task.

I'm -0 (maybe even -1) to always build in 2 steps

I'm +1 to add a goal or any other property to support building in 2
steps. For example:

- Define the following properties in war's plugin.properties file:

maven.war.src.extra = ${maven.build.dir}/war

- Modify plugin.jelly to:

    <war warfile="${maven.war.build.dir}/${maven.war.final.name}"
         webxml="${maven.war.webxml}" update="true">
[...]
      <j:if test="${SrcExtraDirExists == 'true'}">
        <fileset dir="${maven.war.src.extra}"/>
      </j:if>

-Vincent

[snip]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to