Message:

  A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:

  http://jira.codehaus.org/secure/ViewIssue.jspa?key=MAVEN-545


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MAVEN-545
    Summary: Checkstyle should not require header file
       Type: Improvement

     Status: Unassigned
   Priority: Major

 Time Spent: Unknown
  Remaining: 15 minutes

    Project: maven
 Components: 
             plugin-other
   Versions:
             1.0-beta-10

   Assignee: 
   Reporter: Bruce Chenoweth

    Created: Thu, 3 Jul 2003 9:14 AM
    Updated: Thu, 3 Jul 2003 9:14 AM
Environment: Win2K

Description:
In the latest HEAD, the checkstyle-2.0-SNAPSHOT plugin (plugin.jelly r1.10) seems to 
require a header file before even attempting to execute checkstyle.  

Since this may or may not be part of a group's coding standards, this should not be 
required.

I propose the following change:
 - if 'maven.checkstyle.header.file' is set to blank, allow checkstyle to run.

As an aside, the warning should also be modified to fit within 80 columns (it wraps 
very poorly in a Windows command shell).

See the following diff report:
77c77
<       
---
> 
78a79,81
>         <j:when test="${empty(maven.checkstyle.header.file)}">
>           <ant:property name="checkstyleShouldRun" value="true"/>
>         </j:when>
81,84c84,87
<             ======================================================================
<             =                             W A R N I N G                          =
<             ======================================================================
<             =  Your project doesn't contain a header file specified as:          =
---
>             ===================================================================
>             =                             W A R N I N G                       =
>             ===================================================================
>             =  Your project doesn't contain a header file specified as:       =
86,90c89,93
<             =  Checkstyle needs it to check the existence of the License in your =
<             =  source files. If it can't find this file, it throws an error.     =
<             =  A temporary solution is to create an empty LICENSE.txt file.      =
<             =  Though, we recommend that you edit this License.                  =
<             ======================================================================
---
>             =  Checkstyle needs it to check the existence of the License in   =
>             =  your source files. If it can't find this file, it throws an    =
>             =  error. A temporary solution is to create an empty LICENSE.txt  =
>             =  file.  Though, we recommend that you edit this License.        =
>             ===================================================================



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to