A great question! I was trying to just make baby step changes since I dont' really know my way around that well.
I kinda thought so as well. It seemed very odd to have to go put a maven.pmd.enable=true into my project.properties. If no one beats me to it, I'll take a stab at doing that as well. Eric -----Original Message----- From: [EMAIL PROTECTED] To: Maven Developers List Sent: 7/22/03 10:03 PM Subject: Re: cvs commit: maven/src/plugins-build/pmd plugin.jelly Shouldn't pmd be enabled via the <reports> element like all the others??? -- dIon Gillard, Multitask Consulting Blog: http://blogs.codehaus.org/people/dion/ [EMAIL PROTECTED] wrote on 23/07/2003 01:57:56 AM: > epugh 2003/07/22 08:57:56 > > Modified: src/plugins-build/pmd plugin.jelly > Log: > Small fix to if statement! Jelly can be tricky! > > Revision Changes Path > 1.7 +1 -2 maven/src/plugins-build/pmd/plugin.jelly > > Index: plugin.jelly > =================================================================== > RCS file: /home/cvs/maven/src/plugins-build/pmd/plugin.jelly,v > retrieving revision 1.6 > retrieving revision 1.7 > diff -u -r1.6 -r1.7 > --- plugin.jelly 22 Jul 2003 07:05:11 -0000 1.6 > +++ plugin.jelly 22 Jul 2003 15:57:56 -0000 1.7 > @@ -43,8 +43,7 @@ > <!-- Only run PMD if it is enabled --> > <j:set var="enable" value="${maven.pmd.enable}"/> > > - <!-- Either am bloody dumb or this is the only way to make it > work ?! --> > - <j:if test="${enable.toString().equalsIgnoreCase('true')}"> > + <j:if test="${enable == 'true'}"> > <attainGoal name="pmd:report"/> > </j:if> > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] >
