dion 2003/07/27 20:55:10
Modified: src/java/org/apache/maven/cli CLIManager.java
Log:
Add back ben's comment
Revision Changes Path
1.11 +6 -4 maven/src/java/org/apache/maven/cli/CLIManager.java
Index: CLIManager.java
===================================================================
RCS file: /home/cvs/maven/src/java/org/apache/maven/cli/CLIManager.java,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- CLIManager.java 27 Jul 2003 23:33:57 -0000 1.10
+++ CLIManager.java 28 Jul 2003 03:55:10 -0000 1.11
@@ -92,10 +92,12 @@
{
options = new Options();
- /*
- * XXX the usage here looks broken / confusing.
- * If .create is static, then it can't be using the longopt / description
state
- * Which then raises the question, are we misusing OptionBuilder?
+ /*
+ * Although this looks broken and confusing, it is by design (commons-cli,
not ours).
+ * It only presents an issue if this can be called in multiple threads in
the
+ * same classloader simultaneously. Which it can't, as this is a static
initializer.
+ * The new commons-cli fixes the Builder pattern to work in a better way
(OptionBuilder
+ * no longer static).
*/
options.addOption( OptionBuilder
.withLongOpt( "nobanner" )
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
