Message:

   The following issue has been closed.

   Resolver: dion gillard
       Date: Mon, 4 Aug 2003 1:49 AM

Applied
---------------------------------------------------------------------
View the issue:

  http://jira.codehaus.org/secure/ViewIssue.jspa?key=MAVEN-408


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MAVEN-408
    Summary: [j2ee] fixes to plugin.jelly
       Type: Bug

     Status: Closed
   Priority: Minor
 Resolution: FIXED

 Time Spent: Unknown
  Remaining: 0 minutes

    Project: maven
 Components: 
             plugin-war
   Fix Fors:
             1.0-rc1
   Versions:
             1.0-beta-10

   Assignee: 
   Reporter: Joe Germuska

    Created: Sat, 19 Apr 2003 9:26 PM
    Updated: Mon, 4 Aug 2003 1:49 AM

Description:
When attempting to attain the j2ee:validate-war goal, I got the following error:

    [warvalidator] [ERROR] Error in class org.apache.maven.j2ee.WarValidator

BUILD FAILED
java.lang.NoClassDefFoundError: org/apache/commons/logging/LogFactory

Looking at plugin.jelly for the j2ee plugin, I saw that the ant:taskdef for the 
"warvalidator" task did not include commons-logging.  Adding it solved the problem.

Also, I suspect that in common use, the war plugin gets initialized before 
j2ee:validate-war gets called, but in my case I was attempting  to achieve the goal 
directly.  The problem was that maven.war.build.dir was undefined, making the 
following set variable have an unexpected result:
    <j:set var="warBuildDir"
      
value="${pom.getPluginContext('maven-war-plugin').getVariable('maven.war.build.dir')}"/>


By adding "war:init" as a prereq to the j2ee:validate-war goal, this problem was 
solved.  It makes me wonder whether the validate-war goal shouldn't just be rolled 
into the "war" plugin instead, but maybe there's some history I don't know yet.  

The attached patch deals with both of these issues.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to