The following comment has been added to this issue:

     Author: Rafal Krzewski
    Created: Wed, 6 Aug 2003 6:25 AM
       Body:
One more little request - parameterless getCvsRool and getCvsModule
methods are no longer used, and should be removed to decrease clutter.

-[cut]-------------------------------------------------------------
Index: Repository.java
===================================================================
RCS file: /home/cvspublic/maven/src/java/org/apache/maven/project/Repository.java,v
retrieving revision 1.14
diff -u -r1.14 Repository.java
--- Repository.java     5 Aug 2003 15:05:57 -0000       1.14
+++ Repository.java     6 Aug 2003 11:18:22 -0000
@@ -143,36 +143,6 @@
     {
         return url;
     }
-
-    /**
-     * Get cvs root.
-     *
-     * @return CVS root.
-     */
-    public String getCvsRoot()
-    {
-        if ( isValid( getConnection() ) )
-        {
-            return getConnection().substring( 0, connection.lastIndexOf( ":" ) 
).substring( 7 );
-        }
-
-        return null;
-    }
-
-    /**
-     * Get cvs module.
-     *
-     * @return CVS module.
-     */
-    public String getCvsModule()
-    {
-        if ( isValid( getConnection() ) )
-        {
-            return getConnection().substring( connection.lastIndexOf( ":" ) + 1 );
-        }
-
-        return null;
-    }
     
     /**
      * Get cvs server.
-[cut]-------------------------------------------------------------

---------------------------------------------------------------------
View the issue:

  http://jira.codehaus.org/secure/ViewIssue.jspa?key=MAVEN-595


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MAVEN-595
    Summary: Resurrect <developerConnection> & improve CVS usage page
       Type: Improvement

     Status: Closed
   Priority: Minor
 Resolution: FIXED

 Time Spent: Unknown
  Remaining: Unknown

    Project: maven
 Components: 
             core
             plugin-changes
   Fix Fors:
             1.0-rc1

   Assignee: dion gillard
   Reporter: Rafal Krzewski

    Created: Mon, 21 Jul 2003 8:24 AM
    Updated: Tue, 5 Aug 2003 10:15 AM

Description:
I noticed that project/repository/developerConnection element of the POM
was completly ignored by Maven. Thus I have prepared a patch that brings it back to 
life: 

The entered  connection string is used by the changes, file-activity and 
developer-activity plugins in the situation where <connection> element
is missing. 

Anonymous connection is preferred over the authenticated
when both are configured.

I have also improved the cvs-usage page. Information about developer
connection details is displayed using correct data, and sections of 
the page are included conditionally depending on what elements are
present in <repository>:
- Anonymous CVS Access if <connection> is present
- Developer CVS Access via SSH if <developerConnection> is present
- Web Access and CVS Access behind a firewall if <url> is present



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to