The following comment has been added to this issue:

     Author: Alwyn Schoeman
    Created: Tue, 18 Nov 2003 12:11 AM
       Body:
Hi,

I am using 1.0-rc2 from CVS at the moment and bundling something of type sar doesn't 
work with ear plugin 1.2-SNAPSHOT.

Could you expand on where you made the change so that it can be verified if it is 
still there?
---------------------------------------------------------------------
View the issue:

  http://jira.codehaus.org/secure/ViewIssue.jspa?key=MPEAR-3


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPEAR-3
    Summary: Add ability to bundle sar file in ear plugin
       Type: Improvement

     Status: Closed
   Priority: Minor
 Resolution: FIXED

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-ear-plugin
   Fix Fors:
             1.3
   Versions:
             1.2

   Assignee: 
   Reporter: Alwyn Schoeman

    Created: Tue, 26 Aug 2003 11:01 PM
    Updated: Tue, 18 Nov 2003 12:11 AM

Description:
The ability to bundle a JBoss sar file into an ear when type is specified as being sar 
in the dependency.

E.g:
    <dependency>
      <groupId>jboss-services</groupId>
      <artifactId>sms</artifactId>
      <version>SNAPSHOT</version>
      <type>sar</type>
      <properties>
        <ear.bundle>true</ear.bundle>
      </properties>
    </dependency>

The file will then be fetched from the sars artifact directory.

The reason why this doesn't work at the moment is that the ear plugin doesn't test for 
sar and thus doesn't bundle the sar.

This can be achieved by adding the following to the plugin.jelly of the ear plugin 
where the other tests are:           

<j:if test="${dep.type == 'sar'}">
   <j:set var="bundle" value="true"/>
</j:if>

Note that it must NOT be added as a module in the generated application.xml.

This will do for the moment, in future maybe generation of jboss-app.xml could be 
added.




---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to