"Vincent Massol" <[EMAIL PROTECTED]> wrote on 20/11/2003 06:50:41 PM:
> > > > -----Original Message----- > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > > Sent: 20 November 2003 04:34 > > To: Maven Developers List > > Subject: Re: cvs commit: maven-plugins/caller/xdocs changes.xml > > navigation.xml > > > > [EMAIL PROTECTED] wrote on 17/11/2003 12:01:08 AM: > > > > > vmassol 2003/11/16 05:01:08 > > > > > > Modified: caller plugin.jelly project.xml > > > caller/xdocs changes.xml navigation.xml > > > Log: > > > - Fixed bug apparently due to some changes in maven core. > > > ${plugin} seems to now reference the calling plugin and not this > plugin. > > > > > [snip] > > > > > + value="${pom.getPluginContext('maven-caller-plugin'). > > > findVariable(callProperty)}"/> > > > > Can we please use the pluginVar tag for these sorts of things instead > of > > relying on pom.getPluginContext...? > > I would have but for the fact that pluginVar uses getVariable instead of > findVariable. Are you ok to modify pluginVar to use findVariable > instead? Sure, that makes some sense based on how PluginManager constructs the plugin context. > Also, I've found the need for a common pattern: Some properties are > defined in plugin.properties but users can also override them. I would > like to either modify the pluginVar tag name (and logic) or create a new > one that does: > > - look for a property in the pom context first (using findVariable) > - if not found, look for it in a given plugin context (using > findvariable) The above two are what pluginVar should do. Changing it sounds like a good idea. > - if not found, raise an error That should be isolated into something similar to paramCheck. [snip] -- dIon Gillard, Multitask Consulting Blog: http://blogs.codehaus.org/people/dion/ --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
