Sounds right. Thanks.

> -----Original Message-----
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] 
> Sent: Wednesday, 10 December 2003 10:52 AM
> To: Maven Developers List
> Subject: RE: cvs commit: maven-plugins/checkstyle project.xml
> 
> 
> AFAIK, the fix I made is correct.
> 
> here's the taskedef:
> 
>       <ant:taskdef name="checkstyle"
>         classname="com.puppycrawl.tools.checkstyle.CheckStyleTask">
>         <ant:classpath>
>           <ant:pathelement location= 
> "${plugin.getDependencyPath('checkstyle:checkstyle')}"/>
>           <ant:pathelement location= 
> "${plugin.getDependencyPath('checkstyle:checkstyle-optional')}"/>
>           <ant:pathelement location= 
> "${plugin.getDependencyPath('checkstyle:checkstyle')}"/>
>           <ant:pathelement location= 
> "${plugin.getDependencyPath('antlr:antlr')}"/>
>           <ant:pathelement location= 
> "${plugin.getDependencyPath('regexp:regexp')}"/>
>           <ant:pathelement location= 
> "${plugin.getDependencyPath('commons-beanutils:commons-beanutils')}"/>
>           <ant:pathelement location= 
> "${plugin.getDependencyPath('commons-collections:commons-colle
> ctions')}"/>
>           <ant:pathelement location= 
> "${plugin.getDependencyPath('commons-logging:commons-logging')}"/>
>           <ant:path refid="maven.dependency.classpath"/>
>           <ant:pathelement path="${maven.build.dest}"/>
>         </ant:classpath>
>       </ant:taskdef>
> 
> You'll note that it specifies the classpath completely. 
> AFAIK, this will 
> allow ant to load it without being in the root classloader.
> 
> I can't see why checkstyle:checkstyle needs to be in there 
> twice, or why 
> it would need to be in the root classloader, when it's 
> explicitly defined.
> --
> dIon Gillard, Multitask Consulting
> Blog:      http://blogs.codehaus.org/people/dion/
> 
> 
> 
> Brett Porter <[EMAIL PROTECTED]> wrote on 10/12/2003 
> 09:40:35 AM:
> 
> > Checkstyle may need to be in there. I think it was 
> commons-* etc that
> cause
> > the incompatible class change error in the branch though.
> > 
> > I guess if the classpath is set properly to the ant task instead of 
> > the
> old
> > way it shouldn't be needed, so it would be good to remove them.
> > 
> > - Brett
> > 
> > > -----Original Message-----
> > > From: Vincent Massol [mailto:[EMAIL PROTECTED]
> > > Sent: Wednesday, 10 December 2003 1:48 AM
> > > To: 'Maven Developers List'
> > > Subject: RE: cvs commit: maven-plugins/checkstyle project.xml
> > > 
> > > 
> > > dIon,
> > > 
> > > Is that true? I can't remember but I think I've tried without
> > > them and there was a problem with the checkstyle Ant task 
> definition.
> > > 
> > > Thanks
> > > -Vincent
> > > 
> > > > -----Original Message-----
> > > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
> > > > Sent: 09 December 2003 14:33
> > > > To: [EMAIL PROTECTED]
> > > > Subject: cvs commit: maven-plugins/checkstyle project.xml
> > > > 
> > > > dion        2003/12/09 05:33:13
> > > > 
> > > >   Modified:    checkstyle project.xml
> > > >   Log:
> > > >   dependencies don't need to go on root classloader, as they are
> > > > explicitly referenced in the plugin.jelly.
> > > > 
> > > > 
> > > > 
> > > >   This was breaking the 1.0 branch.
> > > > 
> > > >   Revision  Changes    Path
> > > >   1.29      +0 -21     maven-plugins/checkstyle/project.xml
> > > > 
> > > >   Index: project.xml
> > > > 
> > > 
> ===================================================================
> > > >   RCS file: /home/cvs/maven-plugins/checkstyle/project.xml,v
> > > >   retrieving revision 1.28
> > > >   retrieving revision 1.29
> > > >   diff -u -r1.28 -r1.29
> > > >   --- project.xml   16 Nov 2003 10:03:02 -0000   1.28
> > > >   +++ project.xml   9 Dec 2003 13:33:13 -0000   1.29
> > > >   @@ -90,57 +90,36 @@
> > > >          <groupId>antlr</groupId>
> > > >          <artifactId>antlr</artifactId>
> > > >          <version>2.7.2</version>
> > > >   -      <properties>
> > > >   -        <classloader>root</classloader>
> > > >   -      </properties>
> > > >        </dependency>
> > > >        <dependency>
> > > >          <groupId>checkstyle</groupId>
> > > >          <artifactId>checkstyle</artifactId>
> > > >          <version>3.2</version>
> > > >   -      <properties>
> > > >   -        <classloader>root</classloader>
> > > >   -      </properties>
> > > >        </dependency>
> > > >        <dependency>
> > > >          <groupId>checkstyle</groupId>
> > > >          <artifactId>checkstyle-optional</artifactId>
> > > >          <version>3.2</version>
> > > >   -      <properties>
> > > >   -        <classloader>root</classloader>
> > > >   -      </properties>
> > > >        </dependency>
> > > >        <dependency>
> > > >          <groupId>regexp</groupId>
> > > >          <artifactId>regexp</artifactId>
> > > >          <version>1.2</version>
> > > >   -      <properties>
> > > >   -        <classloader>root</classloader>
> > > >   -      </properties>
> > > >        </dependency>
> > > >        <dependency>
> > > >          <groupId>commons-beanutils</groupId>
> > > >          <artifactId>commons-beanutils</artifactId>
> > > >          <version>1.6.1</version>
> > > >   -      <properties>
> > > >   -        <classloader>root</classloader>
> > > >   -      </properties>
> > > >        </dependency>
> > > >        <dependency>
> > > >          <groupId>commons-collections</groupId>
> > > >          <artifactId>commons-collections</artifactId>
> > > >          <version>2.1</version>
> > > >   -      <properties>
> > > >   -        <classloader>root</classloader>
> > > >   -      </properties>
> > > >        </dependency>
> > > >        <dependency>
> > > >          <groupId>commons-logging</groupId>
> > > >          <artifactId>commons-logging</artifactId>
> > > >          <version>1.0.3</version>
> > > >   -      <properties>
> > > >   -        <classloader>root</classloader>
> > > >   -      </properties>
> > > >        </dependency>
> > > >      </dependencies>
> > > >    </project>
> > > > 
> > > > 
> > > > 
> > > > 
> > > > 
> > > 
> --------------------------------------------------------------------
> > > -
> > > > To unsubscribe, e-mail: [EMAIL PROTECTED] For 
> > > > additional commands, e-mail: [EMAIL PROTECTED]
> > > 
> > > 
> > > 
> > > 
> --------------------------------------------------------------------
> > > -
> > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > For additional commands, e-mail: [EMAIL PROTECTED]
> > > 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 

Reply via email to