On Tue, May 20, 2014 at 5:47 AM, Hervé BOUTEMY <herve.bout...@free.fr>wrote:
> > 1) Is there no automatic checkstyle verification as part of the build? We
> > use it in the android-maven-plugin and I though it was standard practice
> > across the Maven projects.
>
> it's only done on site generation, and you can simply ignore the result
> does android-maven-plugin have more aggressive configuration?
>
Yes. Std build fails unless it complies.
IMO that's what you need since it is the developer committing code that has
the understanding necessary to provide the Javadoc comments. And invariably
it is the Javadoc comments that suffer.
> 2) Why is the following one of the Java code conventions? Why would you
> > remove that information from the compiler? I always work to the exact
> > opposite of that unless I need to conform with a tool that uses
> reflection
> > and can't handle final variables.
> >
> > - *Modifier*: Avoid using final modifier on all member variables and
> > arguments.
> I don't understand what you're talking about here
>
One of the Maven Java code conventions (listed on that page) is to
- Avoid using final modifier on all member variables and arguments.
I was just querying the sanity of that. All the other code conventions
either make sense or are a reasonable arbitrary decision. This one appears
to be the exact opposite of what should be done.
William
