Github user a-horst commented on the pull request:

    https://github.com/apache/maven/pull/22#issuecomment-46325077
  
    I already got it running in Eclipse (pretty straight forward with m2e 
etc.). Actually the failed test [MNG-4625] 
(http://jira.codehaus.org/browse/MNG-4625) never seemed to have passed: see the 
respective job history of [core-it-maven-3-win] 
(https://builds.apache.org/view/M-R/view/Maven%20Core%20ITs%20(unstable)/job/core-it-maven-3-win/).
    
    I could narrow down the problem to the use of the special characters in the 
command which are the actual subject of the test (the property 
```test.prop=&x=y<>```). However they seem to break the eventual execution of 
the Maven build for the IT. While the CmdShell (the concrete Shell for Windows; 
see [maven-shared-utils] 
(https://github.com/apache/maven-shared/tree/trunk/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/cli))
 correctly quotes the shell invocation it seems like for the Maven execution 
(on Windows) the special characters need to be quoted as well.
    
    I adjusted the IT to use a quoted assignment and the IT succeeds:
    ```
    verifier.setSystemProperty( "test.prop", "\"&x=y<>\"" );
    ```
    instead of
    ```
    verifier.setSystemProperty( "test.prop", "&x=y<>" );
    ```
    
    Taking into account that MNG-4625 apparently never succeeded on Windows, I 
guess we can say that ITs succeeded with the proposed changes (I just simply 
didn't run ITs on Unix).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to