I suspect defaulting to UTF-8/LEF will work "ok" for most people, I will do some tests on windows.
There's probably 1 billion chinese that rely on CP936 platform default encoding on windows XP (IE6 all over again....) but I suspect they will be better of making an explicit specification of the encoding anyway; they are after all making a zip file that will extract properly "only" on Windows XP (I realize I know way too little about this to be making such a bold statement....). I will investigate some modern windows. I suppose this may cook down to various unicode normalization forms on different OS'es. Does commons compress deal with mac-os unicode normalization ? (e.g does it handle Piñata on mac over to a PC ) ? Kristian 2014-10-10 13:08 GMT+02:00 Stefan Bodewig <bode...@apache.org>: > On 2014-10-10, Kristian Rosenvold wrote: > >> This will break builds for people that actually *want* archives in >> file.encoding; they will need to explicitly specify encoding to get >> that encoding. To my understanding this is not really an issue, LEF >> support is ancient history. > > At the time where I wrote > http://commons.apache.org/proper/commons-compress/zip.html#Encoding the > "compressed folder" feature of Windows (XP by then) completely ignored > the langauage encoding flag and always assumed ZIPs to use the same > native encoding as the system that extracted the archive. > > I've just now re-tested it on a Windows 7 VM and the file names were > correct for files using German Umlauts but wrong for files using the > Euro-glyph. As such I'm not convinced LEF works correctly for Windows, > you may want to perform some tests of your own - and I'll as people on > the commons-user list for additional data points. > > Stefan > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
