@Dennis, I committed the fix, Please verify @maven dev, this vote is cancelled
@Karl, thank you for last release work, I will go thru the release next time -Dan On Tue, Jan 13, 2015 at 12:52 AM, Dan Tran <[email protected]> wrote: > Thanks Dennis, the typo is already fixed before the vote. > > I will rename the passphraseServerKey to passphraseServerId per your > suggestion > > -D > > On Tue, Jan 13, 2015 at 12:08 AM, Dennis Lundberg <[email protected]> > wrote: > >> Hi, >> >> I had a quick look at the fix for >> http://jira.codehaus.org/browse/MGPG-31 >> at >> >> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-gpg-plugin/src/main/java/org/apache/maven/plugin/gpg/AbstractGpgMojo.java?r1=1647942&r2=1647941&pathrev=1647942 >> >> Unfortunately the new parameter is misspelled: >> "gpg.passphaseServerKey" (it's missing an 'r') >> Also the name should really use "id" instead of "key" since it >> references a server id in settings.xml. Using the word "key" might >> also confuse users as it is used frequently in the realm of signing. >> >> Therefor I'm -1 on this release. >> If the release is cancelled I can make the fixes I proposed above. >> >> >> On Mon, Jan 12, 2015 at 10:51 PM, Karl Heinz Marbaise <[email protected]> >> wrote: >> > Hi, >> > >> > We solved 4 issues: >> > >> http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11431&version=20125 >> > >> > There are still a couple of issues left in JIRA: >> > >> http://jira.codehaus.org/issues/?jql=project%20%3D%20MGPG%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC >> > >> > Staging repo: >> > https://repository.apache.org/content/repositories/maven-1123 >> > >> > >> https://repository.apache.org/content/repositories/maven-1123/org/apache/maven/plugins/maven-gpg-plugin/1.6/maven-gpg-plugin-1.6-source-release.zip >> > >> > Source release checksum(s): >> > maven-gpg-plugin-source-release.zip sha1: >> > bf4fe7c98db5cd585015d9d45c1e6f5420f92058 >> > >> > Staging site: >> > http://maven.apache.org/plugins-archives/maven-gpg-plugin-LATEST/ >> > >> > Guide to testing staged releases: >> > http://maven.apache.org/guides/development/guide-testing-releases.html >> > >> > Vote open for 72 hours. >> > >> > [ ] +1 >> > [ ] +0 >> > [ ] -1 >> > >> > Kind regards >> > Karl Heinz Marbaise >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [email protected] >> > For additional commands, e-mail: [email protected] >> > >> >> >> >> -- >> Dennis Lundberg >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> >
