Hi Hervé,
I actually wanted to revert this, because the reason is not 100% correct,
but I don't wonder if anyone will notice:
- the code itself can be built perfectly fine with JDK5.
- For the project using this plugin it requires at least JDK8 to *run the
maven-jdeps-plugin*, the project code itself can and probably will be
compiled with a lower version (I haven't checked it with JDK5, but you
might wonder if that's interesting enough). That's the main reason why I
added extra toolchain support, so can use different toolchains per plugin.
- 3.0-SNAPSHOT means first of all Maven-3.x compatible, and not JDK6
compatible. In fact: Maven-3.0.x and Maven 3.1.x are JDK5 versions, which
would actually mean that the plugin should still be built with JDK5.
Regarding the last bullet: we would make our life easier if we in say that
3.x Maven Plugins require both Maven 3.x AND JDK6.
For that reason I'll keep it like this.
thanks,
Robert
Op Fri, 20 Feb 2015 04:35:27 +0100 schreef <[email protected]>:
Author: hboutemy
Date: Fri Feb 20 03:35:27 2015
New Revision: 1661054
URL: http://svn.apache.org/r1661054
Log:
source=target=1.6 since that's the minimum supported by JDK 9 (and
consistent with version 3.0-SNAPSHOT choice)
Modified:
maven/plugins/trunk/maven-jdeps-plugin/pom.xml
Modified: maven/plugins/trunk/maven-jdeps-plugin/pom.xml
URL:
http://svn.apache.org/viewvc/maven/plugins/trunk/maven-jdeps-plugin/pom.xml?rev=1661054&r1=1661053&r2=1661054&view=diff
==============================================================================
--- maven/plugins/trunk/maven-jdeps-plugin/pom.xml (original)
+++ maven/plugins/trunk/maven-jdeps-plugin/pom.xml Fri Feb 20 03:35:27
2015
@@ -44,6 +44,8 @@ under the License.
<properties>
<mavenVersion>3.0</mavenVersion>
+ <maven.compiler.source>1.6</maven.compiler.source><!-- JDK 9:
Source option 1.5 is no longer supported. Use 1.6 or later. -->
+ <maven.compiler.target>1.6</maven.compiler.target><!-- JDK 9:
Target option 1.5 is no longer supported. Use 1.6 or later. -->
</properties>
<dependencies>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
