I've just replaced some jsl with dom4j editing for simple stuff.

If you turn on pretty print you end up with spaces in the middle of tags
(not in the content, but in the tags), which is not valid XML.
If you turn off pretty print you end up with an unbelievable amount of
whitespace (more than is in the JSL file from what I can tell).

I couldn't find the dom4j options (turning off trim text made it worse), so
I'll have to come back to it later.

- Brett

> -----Original Message-----
> From: Vincent Massol [mailto:[EMAIL PROTECTED] 
> Sent: Monday, 8 March 2004 5:43 PM
> To: 'Maven Developers List'
> Subject: RE: changes.xml modifications (was RE: cvs commit: 
> maven-plugins/scm/xdocs changes.xml)
> 
> 
> Unfortunately, no :-) (I have never used dom4j). I don't 
> think you'll find any option for this kind of thing. It has 
> to be coded with some rules like:
> 
> - offset by 2 spaces right to the previous line position of 
> the <action> element
> - find out word tokens and ensure the words wrap at 78 chars 
> (except if not possible).
> 
> Not easy but doable. BTW, I did something similar some time 
> ago for the announcement plugin (see announcement.jsl).
> 
> Thanks
> -Vincent
> 
> > -----Original Message-----
> > From: Brett Porter [mailto:[EMAIL PROTECTED]
> > Sent: 07 March 2004 22:56
> > To: 'Maven Developers List'
> > Subject: RE: changes.xml modifications (was RE: cvs commit: maven- 
> > plugins/scm/xdocs changes.xml)
> > 
> > Do you know appropriate dom4j formatting options for this?
> > 
> > Thanks,
> > Brett
> > 
> > > -----Original Message-----
> > > From: Vincent Massol [mailto:[EMAIL PROTECTED]
> > > Sent: Sunday, 7 March 2004 7:50 PM
> > > To: 'Maven Developers List'
> > > Subject: changes.xml modifications (was RE: cvs commit: 
> > > maven-plugins/scm/xdocs changes.xml)
> > >
> > >
> > > Hi Brett,
> > >
> > > Why are you reformatting all the changes.xml files?
> > >
> > > I much preffered the old way, i.e.
> > >
> > > <action dev="brett" type="fix" issue="MPSCM-4">
> > >   Update POM using dom4j instead of JSL - no more 
> formatting issues. 
> > > </action>
> > >
> > > Instead of:
> > >
> > > <action dev="brett" type="fix" issue="MPSCM-4">Update POM using 
> > > dom4j instead of JSL - no more formatting issues.</action>
> > >
> > > which is:
> > > a/ unreadable
> > > b/ overflows to more than 80 chars
> > >
> > > I assume it may be something you have automated and which is not 
> > > respecting the formatting. Is it possible to revert back?
> > >
> > > Thanks
> > > -Vincent
> > >
> > > > -----Original Message-----
> > > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
> > > > Sent: 07 March 2004 01:37
> > > > To: [EMAIL PROTECTED]
> > > > Subject: cvs commit: maven-plugins/scm/xdocs changes.xml
> > > >
> > > > brett       2004/03/06 16:36:56
> > > >
> > > >   Modified:    scm      project.xml
> > > >                scm/xdocs changes.xml
> > > >   Log:
> > > >   [maven-scm-plugin] prepare release 1.2
> > > >
> > > >   Revision  Changes    Path
> > > >   1.11      +10 -5     maven-plugins/scm/project.xml
> > > >
> > > >   Index: project.xml
> > > >
> > > 
> ===================================================================
> > > >   RCS file: /home/cvs/maven-plugins/scm/project.xml,v
> > > >   retrieving revision 1.10
> > > >   retrieving revision 1.11
> > > >   diff -u -r1.10 -r1.11
> > > >   --- project.xml       4 Mar 2004 18:38:45 -0000       1.10
> > > >   +++ project.xml       7 Mar 2004 00:36:56 -0000       1.11
> > > >   @@ -1,4 +1,5 @@
> > > >    <?xml version="1.0" encoding="UTF-8"?>
> > > >   +
> > > >    <!--
> > > >    /*
> > > >     * Copyright 2001-2004 The Apache Software Foundation.
> > > >   @@ -17,19 +18,19 @@
> > > >     */
> > > >     -->
> > > >
> > > >   -
> > > >    <project>
> > > >      <extend>../project.xml</extend>
> > > >      <id>maven-scm-plugin</id>
> > > >      <name>Maven Source Control Management Plug-in</name>
> > > >   -  <currentVersion>1.2-SNAPSHOT</currentVersion>
> > > >   +  <currentVersion>1.2</currentVersion>
> > > >      <description>A plugin for SCM tasks, currently
> > > CVS.</description>
> > > >      <shortDescription>SCM Plugin for Maven. Requires Maven 1.0 
> > > > RC2.</shortDescription>
> > > >      <url>http://maven.apache.org/reference/plugins/scm/</url>
> > > >
> > > >
> > > <siteDirectory>/www/maven.apache.org/reference/plugins/scm/</s
> > > iteDirecto
> > > ry
> > > > >
> > > >      <repository>
> > > >   -
> > > >
> > > <connection>scm:cvs:pserver:[EMAIL PROTECTED]:/home/cvspu
> > > blic:maven
> > > /s
> > > > rc/plugins-build/scm/</connection>
> > > >   -    <url>http://cvs.apache.org/viewcvs/maven/src/plugins-
> > > > build/scm/</url>
> > > >   +
> > > >
> > > <connection>scm:cvs:pserver:[EMAIL PROTECTED]:/home/cvspu
> > > blic:maven
> > > -
> > > > plugins/scm/</connection>
> > > >   +
> > > >
> > > <developerConnection>scm:cvs:ext:[EMAIL PROTECTED]
> > > org:/home/
> > > cv
> > > > s:maven-plugins/scm/</developerConnection>
> > > >   +    
> <url>http://cvs.apache.org/viewcvs/maven-plugins/scm/</url>
> > > >      </repository>
> > > >      <versions>
> > > >        <version>
> > > >   @@ -47,6 +48,11 @@
> > > >          <name>SNAPSHOT</name>
> > > >          <tag>HEAD</tag>
> > > >        </version>
> > > >   +    <version>
> > > >   +      <id>1.2</id>
> > > >   +      <name>1.2</name>
> > > >   +      <tag>MAVEN_SCM_1_2</tag>
> > > >   +    </version>
> > > >      </versions>
> > > >      <developers>
> > > >        <developer>
> > > >   @@ -68,4 +74,3 @@
> > > >        </dependency>
> > > >      </dependencies>
> > > >    </project>
> > > >   -
> > > >
> > > >
> > > >
> > > >   1.8       +13 -35    maven-plugins/scm/xdocs/changes.xml
> > > >
> > > >   Index: changes.xml
> > > >
> > > 
> ===================================================================
> > > >   RCS file: /home/cvs/maven-plugins/scm/xdocs/changes.xml,v
> > > >   retrieving revision 1.7
> > > >   retrieving revision 1.8
> > > >   diff -u -r1.7 -r1.8
> > > >   --- changes.xml       4 Mar 2004 18:38:45 -0000       1.7
> > > >   +++ changes.xml       7 Mar 2004 00:36:56 -0000       1.8
> > > >   @@ -1,4 +1,5 @@
> > > >   -<?xml version="1.0"?>
> > > >   +<?xml version="1.0" encoding="UTF-8"?>
> > > >   +
> > > >    <!--
> > > >    /*
> > > >     * Copyright 2001-2004 The Apache Software Foundation.
> > > >   @@ -22,45 +23,22 @@
> > > >        <title>Changes</title>
> > > >        <author email="[EMAIL PROTECTED]">Brett Porter</author>
> > > >      </properties>
> > > >   -
> > > >      <body>
> > > >   -    <release version="1.2-SNAPSHOT" date="in CVS">
> > > >   -      <action dev="brett" type="fix">
> > > >   -        Don't use -C - Mac OS X doesn't recognise it
> > > >   -      </action>
> > > >   -      <action dev="brett" type="fix" issue="MPSCM-3">
> > > >   -        Catch exceptions to make sure files don't get moved
> > > > permanently.
> > > >   -      </action>
> > > >   -      <action dev="brett" type="fix" issue="MPSCM-4">
> > > >   -        Update POM using dom4j instead of JSL - no more
> > > formatting
> > > > issues.
> > > >   -      </action>
> > > >   -      <action dev="brett" type="fix">
> > > >   -        Support :local: CVS paths
> > > >   -      </action>
> > > >   -      <action dev="brett" type="add">
> > > >   -        Update changes.xml version and release date 
> on prepare.
> > > >   -      </action>
> > > >   -      <action dev="brett" type="add">
> > > >   -        Use developerConnection first, then standard 
> connection
> > > when
> > > > parsing connection from POM.
> > > >   -      </action>
> > > >   +    <release version="1.2" date="2004-03-07">
> > > >   +      <action dev="brett" type="fix">Don't use -C - Mac OS X
> > > doesn't
> > > > recognise it</action>
> > > >   +      <action dev="brett" type="fix" issue="MPSCM-3">Catch
> > > exceptions
> > > > to make sure files don't get moved permanently.</action>
> > > >   +      <action dev="brett" type="fix" 
> issue="MPSCM-4">Update POM
> > > using
> > > > dom4j instead of JSL - no more formatting issues.</action>
> > > >   +      <action dev="brett" type="fix">Support :local: CVS
> > > paths</action>
> > > >   +      <action dev="brett" type="add">Update changes.xml
> > > version and
> > > > release date on prepare.</action>
> > > >   +      <action dev="brett" type="add">Use
> > > developerConnection first,
> > > > then standard connection when parsing connection from
> POM.</action>
> > > >        </release>
> > > >   -
> > > >        <release version="1.1" date="2003-09-29">
> > > >   -      <action dev="dion" type="update">
> > > >   -        Apply MAVEN-834. Support for scm delimiters
> > > other than ':'
> > > >   -      </action>
> > > >   -      <action dev="brett" type="fix">
> > > >   -        Turn off pretty printing to fix MAVEN-769 - random
> spaces
> > > added
> > > >   -        to project.xml.
> > > >   -      </action>
> > > >   -      <action dev="brett" type="update">
> > > >   -        Add new versions to bottom of list instead of
> > > top to follow
> > > > convention.
> > > >   -      </action>
> > > >   +      <action dev="dion" type="update">Apply MAVEN-834.
> > > Support for
> > > scm
> > > > delimiters other than ':'</action>
> > > >   +      <action dev="brett" type="fix">Turn off pretty printing
> to
> > > fix
> > > > MAVEN-769 - random spaces added to project.xml.</action>
> > > >   +      <action dev="brett" type="update">Add new versions
> > > to bottom
> > > of
> > > > list instead of top to follow convention.</action>
> > > >        </release>
> > > >        <release version="1.0" date="2003-08-31">
> > > >   -      <action dev="brett" type="add">
> > > >   -        Initial creation - support for CVS.
> > > >   -      </action>
> > > >   +      <action dev="brett" type="add">Initial creation -
> > > support for
> > > > CVS.</action>
> > > >        </release>
> > > >      </body>
> > > >    </document>
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: [EMAIL PROTECTED] For 
> > > > additional commands, e-mail: [EMAIL PROTECTED]
> > >
> > >
> > >
> > >
> ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [EMAIL PROTECTED] For 
> > > additional commands, e-mail: [EMAIL PROTECTED]
> > >
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 

Reply via email to