using svn blame, I started to try to figure out why these strange things are here.
the *.formatted was easy to find: http://svn.apache.org/r960848 corresponding to https://issues.apache.org/jira/browse/MASSEMBLY-462 I read quickly this Jira issue, I didn't really catch what created the .formatted file that this exclude was "workarounding" But there is an IT associated: I don't know if it really checks perfectly about that file, but should. And if the IT works without this workaround, we can remove the now unused workaround Still need some investigation For *.filtered, it is more tricky since the code was changed in a little refactoring in http://svn.apache.org/r628941 and svn blame does not work for code at that version Does anybody know how to find the commit that added this exclusion? BTW, removing such code without knowing why it was there is not something I'm ok with: can you revert please and continue together investigations? Thanks Hervé Le mardi 14 juillet 2015 10:58:48 Benson Margulies a écrit : > This code lives in AddFileSetsTask.java. There are no comments. Can > anyone explain it? Can I simply delete it via MASSEMBLY-777? > > final List<String> excludes = fileSet.getExcludes(); > excludes.add( "**/*.filtered" ); > excludes.add( "**/*.formatted" ); > task.setExcludes( excludes ); > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
