I want to point out that the original set of changes here was a complete violation of the principles Jason raised in the first place. It was a completely breaking change, introduced incompatibly. Anyone who had been pushing foo.filtered files around before it was out of luck afterwards.
On Tue, Jul 14, 2015 at 3:58 PM, Robert Scholte <[email protected]> wrote: > I'd say as much as possible. I'm completely aware that not all can be > removed, but a move from 2.x ot 3.x is THE moment to do these kind of > changes. If you take a look at the Mojo's, most of them are already that > much refactored that they are kind of empty classes, extending the same > AbstractMojo. > The fun starts probably with the ITs depending on deprecated goals, but > "single" describes it is the ultimate goal replacing all others. With a bit > of luck it's not that hard to fix. > I would really take this opportunity to do these kind of things with this > 3.0 release. > > Robert > > ps The o.a.m.plugins was a type, I meant o.a.m.plugin (all empty folders...) > > Op Tue, 14 Jul 2015 21:44:12 +0200 schreef Kristian Rosenvold > <[email protected]>: > > >> If point 5.3 is to be interpreted to mean "any" deprecations it officially >> has my minus one, since it's simply not going to happen and it is a silly >> requirement. We're using 3.0.0 to move maven version,not to settle a new >> continent with lots of natives we can oppress. >> >> 5.3 is not a code change, so I cant veto it. But it's as silly as it gets. >> >> >> I thought o.a.m.plugins was /supposed/ to be there, at least that's what I >> renamed everything to ? >> >> Kristian >> >> >> 2015-07-14 21:03 GMT+02:00 Robert Scholte <[email protected]>: >> >>> Op Tue, 14 Jul 2015 20:46:50 +0200 schreef Kristian Rosenvold < >>> [email protected]>: >>> >>> >>> 2015-07-14 20:06 GMT+02:00 Robert Scholte <[email protected]>: >>>> >>>> >>>> Hi Benson, >>>>> >>>>> >>>>> this is not the 3.0 version of a plugin I had in mind. For instance, it >>>>> isn't compatible with all Maven3 versions and there's still a lot of >>>>> cleanup to do[1] >>>>> >>>>> >>>> It's compatible with all 3.x versions, but I did this before your shared >>>> code had any features related to this. I also believe it has most of the >>>> cleanup done. Did you have anything particular in mind ? >>>> >>>> Kristian >>>> >>> >>> Hi Kristian, >>> >>> just the first things that comes to my mind: >>> Scan the code for "deprecated", start by removing the deprecated mojo's: >>> single (and the generated help) are the only valid goals. >>> >>> mvn clean verify -Prun-its -Dinvoker.mavenHome=d:\apache-maven-3.0 fails >>> on my machine >>> >>> any reason why the o.a.m.plugins is still there? >>> >>> thanks, >>> Robert >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
