I've renamed getter methods in question from xPhases to xLifecyclePhases and reimplemented the original ones to preserve full compatibility. Setters were left mostly as is since imo those are not called from outside of maven core. Pull request is submitted for https://issues.apache.org/jira/browse/MNG-5805 .
ITs for for maven core and maven-enforcer report success. I've also run tests in maven-plugins trunk and apart from failures in recent maven-dependency-plugin changes everything looks fine. 2015-07-20 0:51 GMT+03:00 Jason van Zyl <[email protected]>: > Anton changed the type of a public class so I think he’s going to put it > back. It will break all enforcer plugin users which is not good. > > > On Jul 19, 2015, at 5:28 PM, Karl Heinz Marbaise <[email protected]> > wrote: > > > > Hi, > > > > sounds like maven-enforcer needs a fix ? > > > > Might it better to change maven-enforcer as well ? > > > > Apart from Maven 3.3.4 breaking compatibility ? Or is this a good step > into future direction from Maven perspective? > > > > > > Kind regards > > Karl Heinz Marbaise > > On 7/19/15 10:23 PM, Mirko Friedenhagen wrote: > >> The behaviour change was probably introduced with > >> > https://github.com/apache/maven/commit/1d148be82bcf3e16c01477d412f4f9206445a7aa#diff-16983b0795e70151790709d0d16ab0c9R103 > >> > >> Before we had: > >> * Map<String, String> phaseToGoalMapping = null; > >> Now it is: > >> Map<String, LifecyclePhase> phaseToGoalMapping = null; > >> > >> The requirePluginVersions plugin casts the entry to a string, it > >> probably should use String.valueOf or something. > >> Regards Mirko > >> -- > >> http://illegalstateexception.blogspot.com/ > >> https://github.com/mfriedenhagen/ (http://osrc.dfm.io/mfriedenhagen) > >> https://bitbucket.org/mfriedenhagen/ > >> > >> > >> On Sun, Jul 19, 2015 at 10:12 PM, Mirko Friedenhagen > >> <[email protected]> wrote: > >>> This seems to affect project which use <requirePluginVersions> as an > >>> enforcer-rule. After inserting this rule into another project I get a > >>> similar stack trace. > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > >> > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > Thanks, > > Jason > > ---------------------------------------------------------- > Jason van Zyl > Founder, Takari and Apache Maven > http://twitter.com/jvanzyl > http://twitter.com/takari_io > --------------------------------------------------------- > > To think is easy. To act is hard. But the hardest thing in the world is to > act in accordance with your thinking. > > -- Johann von Goethe > > > > > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Regards, Anton.
