Op Sun, 20 Sep 2015 23:33:13 +0200 schreef Robert Scholte
<[email protected]>:
Op Sun, 20 Sep 2015 18:48:30 +0200 schreef Stuart McCulloch
<[email protected]>:
On Sunday, 20 September 2015 at 11:57, Robert Scholte wrote:
Hi,
I've started running the maven-integration-testing[1] project with the
latest jdk9 jigsaw ea.
I have pushed a couple of fixes to avoid too old values for
source+target
and some other fixes.
Now there are 2 tests which suddenly fail:
MavenITmng3864PerExecPluginConfigTest>AbstractMavenIntegrationTestCase.runTest:219->testitMNG3864:70
null expected:<2008-11-09 11:59:03> but was:<null>
MavenITmng3827PluginConfigTest>AbstractMavenIntegrationTestCase.runTest:219->testitMNG3827:70
null expected:<2008-11-09 11:59:03> but was:<null>
After some investigation I can conclude that when the mojo is
configured,
the Date parameters are still null, so it seems like there's an issue
exposes by plexus configuration.
I've tried several times, but I can't recreate these two failures - are
you running with a non-english locale? Do they still fail when you use
jdk8?
It succeeds with JDK7, my current default, so I think it is actually a
jigsaw issue, just need to find a way to confirm it. It is
plexus-configuration which exposes the problem on my machine.
And yes, I'm using the dutch Locale (nl_NL).
The only recent date-related change in the Sisu codebase was a patch I
added for Dennis to use an explicit locale for date formatting:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=470780
Okay, this bug could be the root cause. It seems like the IT hasn't
specified the Maven and/or JDK ranges and/or Locale-check for this
specific issue when to succeed.
With M3.0.5 I see this issue, not with M3.3.3
Does it make any difference if you revert this patch? (it shouldn’t
given the limited formats that Plexus supports, but you never know)
To isolate the problem I've tried to build sisu.plexus [2], which also
requires a fresh snapshots of sisu.inject[3].
The Tycho build is setup to fetch snapshots via P2 if you don’t have
them locally, but when debugging you’ll typically want to build both
locally.
The latter builds fine, but
when trying to build sisu.plexus with jdk9 I get the following error
The JDT compiler used by Tycho doesn’t support Jigsaw yet, so I’ve
added a workaround for now to fall back to javac on jdk9:
http://git.eclipse.org/c/sisu/org.eclipse.sisu.inject.git/commit/?id=c16911ec2790b6cb33c0d0621962a08408b06fc0
http://git.eclipse.org/c/sisu/org.eclipse.sisu.plexus.git/commit/?id=cbc639794b28ca7413ac8f2c19faf5a89b7aa094
Cool, let's see if I can reproduce it
thanks,
Robert
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Sisu Plexus ....................................... SUCCESS
[0.631s]
[INFO] org.eclipse.sisu.plexus ........................... FAILURE
[6.229s]
[INFO] org.eclipse.sisu.plexus.extender .................. SKIPPED
[INFO] org.eclipse.sisu.plexus.tests ..................... SKIPPED
[INFO] org.eclipse.sisu.plexus.site ...................... SKIPPED
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 53.214s
[INFO] Finished at: Sun Sep 20 11:38:00 CEST 2015
[INFO] Final Memory: 35M/72M
[INFO]
------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.eclipse.tycho:tycho-compiler-plugin:0.23.1:compile
(default-compile)
on project org.eclipse.sisu.plexus: Compilation failure:
Compilation failure:
[ERROR]
F:\github-workspace\sisu.plexus\org.eclipse.sisu.plexus\src\org\codehaus\plexus\component\configurator\expression\TypeAwareExpressionEvaluator.java:
[ERROR]
/*******************************************************************************
[ERROR] ^
[ERROR] The type java.lang.Class cannot be resolved. It is indirectly
referenced from required .class files
[ERROR] 1 problem (1 error)
It'll take some extra time to find the actual root cause.
Robert
[1]
https://git-wip-us.apache.org/repos/asf/maven-integration-testing.git
[2] https://github.com/eclipse/sisu.plexus.git
[3] https://github.com/eclipse/sisu.inject.git
Op Wed, 09 Sep 2015 19:16:13 +0200 schreef Rory O'Donnell
<[email protected] (mailto:[email protected])>:
>
> Hi Robert & Kristian,
>
> Early-access builds of JDK 9 with Project Jigsaw are available for
> download at jdk9.java.net/jigsaw <http://jdk9.java.net/jigsaw>.
>
> The EA builds contain the latest prototype implementation of JSR 376
> <http://openjdk.java.net/projects/jigsaw/spec>, the Java Platform
Module
> System,
> as well as that of the JDK-specific APIs and tools described in JEP
261
> <http://openjdk.java.net/jeps/261>.
>
> If you'd like to try out the EA builds, by far the most helpful
things
> you can do are:
>
> *
>
> Try to run existing applications, without change, on these builds to
> see whether the module system, or the modularization of the
> platform, breaks your code or identifies code that depends upon
> JDK-internal APIs or other unspecified aspects of the platform.
>
> *
>
> Experiment with the module system itself, perhaps by following the
> quick start guide
> <http://openjdk.java.net/projects/jigsaw/quick-start>, and start
> thinking about how to migrate existing libraries and application
> components to modules. We hope to publish some specific migration
> tips shortly.
>
> Please send usage questions and experience reports to the jigsaw-dev
> <http://mail.openjdk.java.net/mailman/listinfo/jigsaw-dev> list.
> Specific suggestions about the design of the module system should be
> sent to the JSR 376 Expert Group's comments list
> <mailto:[email protected]>.
>
> For more information please seen Mark Reinhold's mail [1]
>
> Rgds,Rory
>
>
[1]http://mail.openjdk.java.net/pipermail/jigsaw-dev/2015-September/004480.html
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
