Good idea! Funny enough, I've seen multi-module projects that wouldn't work with this - they have an aggregator pom on the top-level, with: <module>componentA/common</module> <module>componentA/server</module> <module>componentB/common</..> .. So they skip a level of aggregator poms (in the componentX-directories).
I'd consider that an edge case, though. The implications that the current approach shows in the examples of the Jira issue seem to be worse. 2015-10-12 20:16 GMT+02:00 Karl Heinz Marbaise <[email protected]>: > Hi, > > based on the changes we have made to identify the folder where ".mvn" is > located i would suggest to enhance the check with checking the pom.xml file > as well...So i would suggest to enhance the find_maven_basedir() function > like the following: > > local basedir="$(pwd)" > local wdir="$(pwd)" > while [ "$wdir" != '/' ] ; do > - if [ -d "$wdir"/.mvn ] ; then > + if [ -d "$wdir"/.mvn ] && [ -e "$wdir"/pom.xml ] ; then > basedir=$wdir > break > fi > > WDYT ? > > See also my comments: > [1]: > https://issues.apache.org/jira/browse/MNG-5858?focusedCommentId=14744204&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14744204 > > Kind regards > Karl Heinz Marbaise > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
