You have a +1 from me. if there's any issue here, which I doubt, it's not worth a -1.
On Sat, Oct 17, 2015 at 1:00 PM, Tibor Digana <[email protected]> wrote: > The doc of "*trimStackTrace*" says > "Whether to trim the stack trace in the reports to just the lines within > the test, or show the full trace." > My bad in previous email. > https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#trimStackTrace > > > On Sat, Oct 17, 2015 at 6:56 PM, Tibor Digana-2 [via Maven] < > [email protected]> wrote: > >> No, we did not short the stack. >> We now properly implemented "*trimStackTrace*", where it works as expected >> in std/out and XML report as well >> "Option to print summary of test suites or just print the test cases that >> have errors." >> >> Please try to set it to false and let me know. >> >> I won't be able to check you conversation till the late evening tomorrow >> when the Vote will be gone. >> >> The Vote will elapse on Sunday 5 a.m. After that we have to options: >> 1. make the regular release, or >> 2. start Take 3 if we want me to fix something. >> >> Honestly making the release Vote of surefire is more painful than >> maven-shared-* staff. >> >> Enjoy the Vote ☺ >> >> >> On Fri, Oct 16, 2015 at 7:25 PM, Benson Margulies <[hidden email] >> <http:///user/SendEmail.jtp?type=node&node=5849436&i=0>> >> wrote: >> >> > On Fri, Oct 16, 2015 at 1:23 PM, Andreas Gudian >> > <[hidden email] <http:///user/SendEmail.jtp?type=node&node=5849436&i=1>> >> wrote: >> > > Benson, is there a full stack trace in the XML test report? I would >> have >> > > expected that we shorten out most of the stack traces on the console >> > > output... >> > >> > No. That's why I complained. >> > >> > >> > > >> > > 2015-10-16 16:35 GMT+02:00 Benson Margulies <[hidden email] >> <http:///user/SendEmail.jtp?type=node&node=5849436&i=2>>: >> > > >> > >> On Fri, Oct 16, 2015 at 10:31 AM, Tibor Digana <[hidden email] >> <http:///user/SendEmail.jtp?type=node&node=5849436&i=3>> >> > >> wrote: >> > >> > Can you give me the link? >> > >> >> > >> >> > >> >> > >> https://github.com/ops4j/org.ops4j.pax.exam2/commit/c466e58cae6c2275a38bc2712cc76a70f768d769 >> > >> >> > >> >> > >> > >> > >> > On Fri, Oct 16, 2015 at 4:27 PM, Benson Margulies [via Maven] < >> > >> > [hidden email] >> <http:///user/SendEmail.jtp?type=node&node=5849436&i=4>> wrote: >> > >> > >> > >> >> I've committed the fix to the master for pax-exam. >> > >> >> >> > >> >> >> > >> >> On Fri, Oct 16, 2015 at 10:19 AM, Benson Margulies >> > >> >> <[hidden email] <http:// >> > >> /user/SendEmail.jtp?type=node&node=5849346&i=0>> >> > >> >> wrote: >> > >> >> >> > >> >> > On Fri, Oct 16, 2015 at 9:56 AM, Tibor Digana >> > >> >> > <[hidden email] <http:// >> > >> /user/SendEmail.jtp?type=node&node=5849346&i=1>> >> > >> >> wrote: >> > >> >> >> try to debug this stack part of ProbeRunner. >> > >> >> >> What version of pax-exam-spi you use? >> > >> >> > >> > >> >> > 4.6.0. I am testing the fix to pax-exam now. >> > >> >> > >> > >> >> >> >> > >> >> >> at org.ops4j.pax.exam.spi. >> > >> >> >> >> > >> >> >> > >> >> > >> reactors.ReactorManager.addConfigurationsToReactor(ReactorManager.java:239) >> > >> >> >> at >> > >> >> >> >> > >> >> >> > >> >> > >> org.ops4j.pax.exam.spi.reactors.ReactorManager.prepareReactor(ReactorManager.java:184) >> >> > >> >> >> > >> >> >> - locked <0x411> (a >> > org.ops4j.pax.exam.spi.reactors.ReactorManager) >> > >> >> >> at >> > >> >> >> org.ops4j.pax.exam.junit.impl.ProbeRunner.<init>(ProbeRunner.java:78) >> > >> >> >> >> > >> >> >> >> > >> >> >> On Fri, Oct 16, 2015 at 3:46 PM, Benson Margulies <[hidden >> email] >> > >> >> <http:///user/SendEmail.jtp?type=node&node=5849346&i=2>> >> > >> >> >> wrote: >> > >> >> >> >> > >> >> >>> Step 1: here's the backtrace of the InvocationTargetException. >> > It's >> > >> >> >>> caused by an IllegalArgumentException, which I will break on >> > next. >> > >> >> >>> >> > >> >> >>> That is in turn, as you supposed, caused by the use of the >> file: >> > >> >> >>> >> > >> >> >>> >> > >> >> >>> >> > >> >> >> > >> >> > >> jar:file:/Users/benson/x/rosapi1.5/itests/tests/target/rosapi-itests-tests.jar!/META-INF/maven/dependencies.properties >> >> > >> >> >> > >> >> >>> >> > >> >> >>> being non-hierarchical. >> > >> >> >>> >> > >> >> >>> So, the underlying issue is a bug in pax-exam. However, I >> still >> > >> wonder >> > >> >> >>> what you think about the fact that failsafe did not provide >> any >> > >> >> >>> backtrace. >> > >> >> >>> >> > >> >> >>> >> > >> >> >>> >> > >> >> >>> "main@1" prio=5 tid=0x1 nid=NA runnable >> > >> >> >>> java.lang.Thread.State: RUNNABLE >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> sun.reflect.NativeMethodAccessorImpl.invoke0(NativeMethodAccessorImpl.java:-1) >> >> > >> >> >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) >> >> > >> >> >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >> >> > >> >> >> > >> >> >>> at java.lang.reflect.Method.invoke(Method.java:497) >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> org.ops4j.pax.exam.spi.reactors.ReactorManager.addConfigurationsToReactor(ReactorManager.java:239) >> >> > >> >> >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> org.ops4j.pax.exam.spi.reactors.ReactorManager.prepareReactor(ReactorManager.java:184) >> >> > >> >> >> > >> >> >>> - locked <0x411> (a >> > org.ops4j.pax.exam.spi.reactors.ReactorManager) >> > >> >> >>> at >> > >> >> >> org.ops4j.pax.exam.junit.impl.ProbeRunner.<init>(ProbeRunner.java:78) >> > >> >> >>> at >> > org.ops4j.pax.exam.junit.PaxExam.createDelegate(PaxExam.java:82) >> > >> >> >>> at org.ops4j.pax.exam.junit.PaxExam.<init>(PaxExam.java:73) >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> sun.reflect.NativeConstructorAccessorImpl.newInstance0(NativeConstructorAccessorImpl.java:-1) >> >> > >> >> >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) >> >> > >> >> >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) >> >> > >> >> >> > >> >> >>> at >> > java.lang.reflect.Constructor.newInstance(Constructor.java:422) >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> org.junit.internal.builders.AnnotatedBuilder.buildRunner(AnnotatedBuilder.java:104) >> >> > >> >> >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> org.junit.internal.builders.AnnotatedBuilder.runnerForClass(AnnotatedBuilder.java:86) >> >> > >> >> >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:59) >> >> > >> >> >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> org.junit.internal.builders.AllDefaultPossibilitiesBuilder.runnerForClass(AllDefaultPossibilitiesBuilder.java:26) >> >> > >> >> >> > >> >> >>> at org.junit.runner.Computer.getRunner(Computer.java:40) >> > >> >> >>> at >> org.junit.runner.Computer$1.runnerForClass(Computer.java:31) >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:59) >> >> > >> >> >> > >> >> >>> at >> > >> >> >> org.junit.runners.model.RunnerBuilder.runners(RunnerBuilder.java:101) >> > >> >> >>> at >> > >> >> >> org.junit.runners.model.RunnerBuilder.runners(RunnerBuilder.java:87) >> > >> >> >>> at org.junit.runners.Suite.<init>(Suite.java:81) >> > >> >> >>> at org.junit.runner.Computer.getSuite(Computer.java:28) >> > >> >> >>> at org.junit.runner.Request.classes(Request.java:75) >> > >> >> >>> at org.junit.runner.Request.classes(Request.java:91) >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> sun.reflect.NativeMethodAccessorImpl.invoke0(NativeMethodAccessorImpl.java:-1) >> >> > >> >> >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) >> >> > >> >> >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >> >> > >> >> >> > >> >> >>> at java.lang.reflect.Method.invoke(Method.java:497) >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> org.apache.maven.surefire.common.junit4.JUnit4Reflector.createRequest(JUnit4Reflector.java:67) >> >> > >> >> >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> org.apache.maven.surefire.common.junit4.JUnit4ProviderUtil.createSuiteDescription(JUnit4ProviderUtil.java:111) >> >> > >> >> >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> org.apache.maven.surefire.junit4.JUnit4Provider.createTestsDescription(JUnit4Provider.java:328) >> >> > >> >> >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:166) >> >> > >> >> >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:286) >> >> > >> >> >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:240) >> >> > >> >> >> > >> >> >>> at >> > >> >> >>> >> > >> >> >> > >> >> > >> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121) >> > >> >> >>> >> > >> >> >>> >> > >> --------------------------------------------------------------------- >> > >> >> >>> To unsubscribe, e-mail: [hidden email] >> > >> >> <http:///user/SendEmail.jtp?type=node&node=5849346&i=3> >> > >> >> >>> For additional commands, e-mail: [hidden email] >> > >> >> <http:///user/SendEmail.jtp?type=node&node=5849346&i=4> >> > >> >> >>> >> > >> >> >>> >> > >> >> >> >> > >> >> >> >> > >> >> >> -- >> > >> >> >> Cheers >> > >> >> >> Tibor >> > >> >> >> > >> >> >> --------------------------------------------------------------------- >> > >> >> To unsubscribe, e-mail: [hidden email] >> > >> >> <http:///user/SendEmail.jtp?type=node&node=5849346&i=5> >> > >> >> For additional commands, e-mail: [hidden email] >> > >> >> <http:///user/SendEmail.jtp?type=node&node=5849346&i=6> >> > >> >> >> > >> >> >> > >> >> >> > >> >> ------------------------------ >> > >> >> If you reply to this email, your message will be added to the >> > discussion >> > >> >> below: >> > >> >> >> > >> >> >> > >> >> > >> http://maven.40175.n5.nabble.com/VOTE-Release-Apache-Maven-Surefire-Plugin-version-2-19-Take-2-tp5849065p5849346.html >> > >> >> To start a new topic under Maven Developers, email >> > >> >> [hidden email] >> <http:///user/SendEmail.jtp?type=node&node=5849436&i=5> >> > >> >> To unsubscribe from Maven Developers, click here >> > >> >> < >> > >> >> > >> > >> > >> >> . >> > >> >> NAML >> > >> >> < >> > >> >> > >> http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml >> > >> > >> > >> >> >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > -- >> > >> > View this message in context: >> > >> >> > >> http://maven.40175.n5.nabble.com/VOTE-Release-Apache-Maven-Surefire-Plugin-version-2-19-Take-2-tp5849065p5849348.html >> > >> > Sent from the Maven Developers mailing list archive at Nabble.com. >> > >> >> > >> --------------------------------------------------------------------- >> > >> To unsubscribe, e-mail: [hidden email] >> <http:///user/SendEmail.jtp?type=node&node=5849436&i=6> >> > >> For additional commands, e-mail: [hidden email] >> <http:///user/SendEmail.jtp?type=node&node=5849436&i=7> >> > >> >> > >> >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [hidden email] >> <http:///user/SendEmail.jtp?type=node&node=5849436&i=8> >> > For additional commands, e-mail: [hidden email] >> <http:///user/SendEmail.jtp?type=node&node=5849436&i=9> >> > >> > >> >> >> -- >> Cheers >> Tibor >> >> >> ------------------------------ >> If you reply to this email, your message will be added to the discussion >> below: >> >> http://maven.40175.n5.nabble.com/VOTE-Release-Apache-Maven-Surefire-Plugin-version-2-19-Take-2-tp5849065p5849436.html >> To start a new topic under Maven Developers, email >> [email protected] >> To unsubscribe from Maven Developers, click here >> <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=142166&code=dGlib3JkaWdhbmFAYXBhY2hlLm9yZ3wxNDIxNjZ8LTI4OTQ5MjEwMg==> >> . >> NAML >> <http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml> >> > > > > > -- > View this message in context: > http://maven.40175.n5.nabble.com/VOTE-Release-Apache-Maven-Surefire-Plugin-version-2-19-Take-2-tp5849065p5849442.html > Sent from the Maven Developers mailing list archive at Nabble.com. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
