Hi Tibort, On 10/21/15 12:53 AM, Tibor Digana wrote:
@Karl Let's suppose you renamed 2.4.2 to 2.5.0. What would be difference in future 3.0.0 in this plugin? Only the plugin Version itself?
Not only..First changing the naming of the properties..location of the dependency-reduced-pom should be changed (https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSHADE%20AND%20fixVersion%20%3D%203.0)..
Kind regards Karl Heinz Marbaise
On Wed, Oct 21, 2015 at 12:48 AM, Karl Heinz Marbaise <[email protected] <mailto:[email protected]>> wrote: Hi, there are two things.. mavenVersion 3.0 is since Maven Shade Plugin 2.0 (http://maven.apache.org/plugins-archives/maven-shade-plugin-2.0/plugin-info.html)... Maven Shade Plugin is one of the exception which is already on Maven 3.X only...Maven 2 version is 1.7.1 So 3.0.0 version would be kind of synching with the release line idea (3.0.0 => Maven 3.X only)...(exception: Maven Site Plugin).. Apart from that Uwe Barthel has mentioned a important thing which makes sense to change to at least 2.5.0 ... Kind regards Karl Heinz Marbaise On 10/21/15 12:36 AM, Tibor Digana wrote: No, no, just a moment. The plugin Version could be 3.0 instead of 2.4.2, right? So we have everything ready for such upgrade which is biggest activity in other plugins this month, this means we have here: <mavenVersion>3.0</mavenVersion> and <parent> <artifactId>maven-plugins</artifactId> <groupId>org.apache.maven.plugins</groupId> <version>28</version> <relativePath>../maven-plugins/pom.xml</relativePath> </parent> We can solve two things within the release: bug fix and major version upgrade. And we save one release. Nobody likes restarting the release Vote, me eigher... On Wed, Oct 21, 2015 at 12:22 AM, Uwe Barthel <[email protected] <mailto:[email protected]>> wrote: -1: for me. (non binding) In respect of http://semver.org/ I suggest the version 2.5.0. The Java version change is a minimum minor change. -- barthel On 20 Oct 2015, at 23:47, Tibor Digana <[email protected] <mailto:[email protected]>> wrote: +1: from me No blocker from my side. Actually Java 5 is already archaic. I guess many users love Java 6+ nowadays. On Tue, Oct 20, 2015 at 11:26 PM, Karl Heinz Marbaise-3 [via Maven] < [email protected] <mailto:ml-node%[email protected]>> wrote: Hi Tibor, On 10/20/15 11:12 PM, Tibor Digana wrote: @Karl Because of maven-parent:27 this plugin is built with J2SE 6.0 = 50 (0x32 hex) The previous version 2.4.1 was @ Java 5. Unfortunately you are correct...(really good catch)... What is intended with this release? It was not intended, cause no related issue is part of the release notes... So the question is: Blocker for the release from your point of view? Kind regards Karl Heinz Marbaise On Fri, Oct 16, 2015 at 11:37 AM, Karl Heinz Marbaise <[hidden email] <http:///user/SendEmail.jtp?type=node&node=5849846&i=0>> wrote: Hi, We solved 6 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921&version=12333008 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSHADE%20AND%20status%20%3D%20Open%20ORDER%20BY%20priority%20DESC Staging repo: https://repository.apache.org/content/repositories/maven-1224 https://repository.apache.org/content/repositories/maven-1224/org/apache/maven/plugins/maven-shade-plugin/2.4.2/maven-shade-plugin-2.4.2-source-release.zip Source release checksum(s): maven-shade-plugin-2.4.2-source-release.zip sha1: a42917c7e6cfa08e122afdd209dc9b8394de2d42 Staging site: http://maven.apache.org/plugins-archives/maven-shade-plugin-LATEST/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 Kind regards Karl Heinz Marbaise
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
