Sure you can close the PR. Put 'Closes #nn.' in a commit message.
On Oct 28, 2015 4:38 PM, "Stephen Connolly" <[email protected]>
wrote:

> I
>
> On Wednesday 28 October 2015, Michael Osipov <[email protected]> wrote:
>
> > Am 2015-10-28 um 18:28 schrieb Stephen Connolly:
> >
> >> Thanks for contributions from non-committers go to:
> >> *  Martin Schäf
> >> * Joseph Walton
> >> * Keith Turner
> >> * Anton Tanasenko
> >> * Stephen Kitt
> >> * "tssp at web dot de" (whoever you are - a small commit with clear
> >> intent of Apache License grant)
> >> * "sugartxy <tgttxy at 163 dot com>" (on technical basis of this
> >> change I think this is acceptable to infer a grant of Apache License)
> >> * Florencia Tarditti
> >> * Robert Stern
> >>
> >
> > That is a good example that if you encourage people to contribute and
> > resolve the PRs in time, they will contribute. Some of the commits have
> > been merged by me and I was quite grateful to those who created a PR,
> > regardless how small the improvement is.
>
>
> Yes, and that is why - as well as giving evidence that I have done my duty
> as a PMC member in reviewing the commits involved in the release *from a
> code provenance point of view* - I called out the names ;-)
>
>
> >
> > Though, the lifecycle on GitHub is still mediocre. I cannot request
> > Jenkins to run the tests, I cannot close the PR. For me who has only
> little
> > time for this, the state is somewhat frustrating.
>
>
> Yes I feel your pain... From some recent debate on the ASF board list,
> others feel your pain and there is some banging of heads to find better
> ways of working while maintaining the core needs of the ASF about
> establishing provenance... I am sure things will get better as time
> progresses ;-)
>
>
> >
> > Michael
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [email protected]
> > For additional commands, e-mail: [email protected]
> >
> >
>
> --
> Sent from my phone
>

Reply via email to