Amazing flute section ! ROFL :) K
2015-11-02 23:46 GMT+01:00 Jason van Zyl <[email protected]>: > One more time > > https://www.youtube.com/watch?v=ry4ngf766N0 > > > On Nov 2, 2015, at 7:26 AM, Stephen Connolly < > [email protected]> wrote: > > > > Well I was asked to remove the quick and dirty check of "is it a > > version range" which lead to: > > > > > https://git1-us-west.apache.org/repos/asf?p=maven.git;a=blobdiff;f=maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java;h=ab00fef6d533c03a8e7bafc714450a663f320518;hp=673a50f5a2de0c8d498de79202f1a18bc30dcbdb;hb=bd87258629db8e3fcc7aa04777afc16314c3cde0;hpb=ec14b8ad4c6613d04e3258101bdbf81588b658a9 > > > > Which is where the regression crept in (only because the docs for > > adding an integration test had not emphasised how important it is to > > add the tests to the suite) > > > > The only other change after that was > > > https://git1-us-west.apache.org/repos/asf?p=maven.git;a=blobdiff;f=maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java;h=3bddfd329ba3b7c584f54a75e5d27bd829b9b56c;hp=ab00fef6d533c03a8e7bafc714450a663f320518;hb=618e62dd3315b4cb5b0f7dcdd37fc787c44b2ade;hpb=b9cc9c3652d43f0efce36d57c0ec1de35d4e7c56 > > which certainly does not affect this code at all > > > > On 2 November 2015 at 14:49, Robert Scholte <[email protected]> > wrote: > >> IIRC, somebody provided a patch to remove this if-statement. Not sure > if it was applied. > >> > >> Robert > >> > >> Verzonden vanaf Samsung Mobile. > >> > >> <div>-------- Oorspronkelijk bericht --------</div><div>Van: Stephen > Connolly <[email protected]> </div><div>Datum:02-11-2015 > 04:18 (GMT-08:00) </div><div>Aan: Maven Developers List < > [email protected]> </div><div>Onderwerp: Re: [VOTE] Maven 3.3.8 > </div><div> > >> </div> > https://git1-us-west.apache.org/repos/asf?p=maven.git;a=commit;h=19532849 > >> is the fix > >> > >> On 2 November 2015 at 12:05, Stephen Connolly > >> <[email protected]> wrote: > >>> -1 technical > >>> > >>> > mng5840ParentVersionRanges(ParentRangeRelativePathPointsToWrongVersion)OK > >>> (5.6 s) > >>> > mng5840ParentVersionRanges(ParentRangeRelativePathPointsToCorrectVersion)OK > >>> (0.4 s) > >>> > mng5840RelativePathReactorMatching(RelativePathPointsToWrongVersion)FAILURE > >>> (0.4 s) > >>> > >>> > >>> > >>> On 2 November 2015 at 11:48, Stephen Connolly > >>> <[email protected]> wrote: > >>>> Hmmm I may have to change my vote, looking like there is a regression > >>>> on the MNG-5840 fix from 3.3.6-SNAPSHOT > >>>> > >>>> On 30 October 2015 at 17:38, Stephen Connolly > >>>> <[email protected]> wrote: > >>>>> +1 technical - works on my critical big build > >>>>> +1 legal umbrella - on the diff of this since 3.3.7 (thankfully only > 1 > >>>>> commit to review there ;-) > >>>>> > >>>>> -Stephen > >>>>> > >>>>> On 30 October 2015 at 17:01, Jason van Zyl <[email protected]> wrote: > >>>>>> +1 > >>>>>> > >>>>>> Analyzing release validity... > >>>>>> > >>>>>> stagingUrl: > https://repository.apache.org/content/repositories/maven-1230 > >>>>>> groupId: org.apache.maven > >>>>>> artifactId: apache-maven > >>>>>> version: 3.3.8 > >>>>>> > >>>>>> Source ZIP url exists. > >>>>>> > https://repository.apache.org/content/repositories/maven-1230/org/apache/maven/apache-maven/3.3.8/apache-maven-3.3.8-src.zip > >>>>>> > >>>>>> Source ZIP SHA1 url exists. > >>>>>> > https://repository.apache.org/content/repositories/maven-1230/org/apache/maven/apache-maven/3.3.8/apache-maven-3.3.8-src.zip.sha1 > >>>>>> > >>>>>> Binary ZIP url exists. > >>>>>> > https://repository.apache.org/content/repositories/maven-1230/org/apache/maven/apache-maven/3.3.8/apache-maven-3.3.8-bin.zip > >>>>>> > >>>>>> Binary ZIP SHA1 url exists. > >>>>>> > https://repository.apache.org/content/repositories/maven-1230/org/apache/maven/apache-maven/3.3.8/apache-maven-3.3.8-bin.zip.sha1 > >>>>>> > >>>>>> Calculated SHA1 of source ZIP matches published SHA1 of source ZIP. > >>>>>> d82dad921c725e716677aed20cf4d2ea90245d33 > >>>>>> > >>>>>> Calculated SHA1 of binary ZIP matches published SHA1 of binary ZIP. > >>>>>> ce9b14315b73ea73f889a347c12cc260c5800dc0 > >>>>>> > >>>>>> LICENSE file is present in the source distribution. > >>>>>> NOTICE file is present in the source distribution. > >>>>>> > >>>>>> LICENSE file is present in the binary distribution. > >>>>>> NOTICE file is present in the binary distribution. > >>>>>> > >>>>>> Git revision of release as determined from > maven-core-3.3.8.jar:org/apache/maven/messages/build.properties(buildNumber): > >>>>>> cdd15915eb4b74ccab621e51aff9ada4f455a627 > >>>>>> > >>>>>> All files in source distribution have been found in the release > revision (taking into account acceptable exclusions). > >>>>>> > >>>>>>> On Oct 30, 2015, at 9:58 AM, Jason van Zyl <[email protected]> > wrote: > >>>>>>> > >>>>>>> Hi, > >>>>>>> > >>>>>>> Time to release Maven 3.3.8! > >>>>>>> > >>>>>>> Here is a link to the issues resolved: > >>>>>>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12333074 > >>>>>>> > >>>>>>> Staging repo: > >>>>>>> https://repository.apache.org/content/repositories/maven-1230/ > >>>>>>> > >>>>>>> The distributable binaries and sources for testing can be found > here: > >>>>>>> > https://repository.apache.org/content/repositories/maven-1230/org/apache/maven/apache-maven/3.3.8/ > >>>>>>> > >>>>>>> Specifically the zip, tarball, and source archives can be found > here: > >>>>>>> > https://repository.apache.org/content/repositories/maven-1230/org/apache/maven/apache-maven/3.3.8/apache-maven-3.3.8-bin.zip > >>>>>>> > https://repository.apache.org/content/repositories/maven-1230/org/apache/maven/apache-maven/3.3.8/apache-maven-3.3.8-bin.tar.gz > >>>>>>> > https://repository.apache.org/content/repositories/maven-1230/org/apache/maven/apache-maven/3.3.8/apache-maven-3.3.8-src.zip > >>>>>>> > https://repository.apache.org/content/repositories/maven-1230/org/apache/maven/apache-maven/3.3.8/apache-maven-3.3.8-src.tar.gz > >>>>>>> > >>>>>>> Source release checksum(s): > >>>>>>> apache-maven-3.3.8-src.zip sha1: > d82dad921c725e716677aed20cf4d2ea90245d33 > >>>>>>> > >>>>>>> Staging site: > >>>>>>> http://people.apache.org/~jvanzyl/maven-3.3.8/ > >>>>>>> > >>>>>>> Vote open for 72 hours. > >>>>>>> > >>>>>>> [ ] +1 > >>>>>>> [ ] +0 > >>>>>>> [ ] -1 > >>>>>>> > >>>>>>> Thanks, > >>>>>>> > >>>>>>> The Maven Team > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > --------------------------------------------------------------------- > >>>>>>> To unsubscribe, e-mail: [email protected] > >>>>>>> For additional commands, e-mail: [email protected] > >>>>>>> > >>>>>> > >>>>>> Thanks, > >>>>>> > >>>>>> Jason > >>>>>> > >>>>>> ---------------------------------------------------------- > >>>>>> Jason van Zyl > >>>>>> Founder, Takari and Apache Maven > >>>>>> http://twitter.com/jvanzyl > >>>>>> http://twitter.com/takari_io > >>>>>> --------------------------------------------------------- > >>>>>> > >>>>>> Simplex sigillum veri. (Simplicity is the seal of truth.) > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> > --------------------------------------------------------------------- > >>>>>> To unsubscribe, e-mail: [email protected] > >>>>>> For additional commands, e-mail: [email protected] > >>>>>> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > Thanks, > > Jason > > ---------------------------------------------------------- > Jason van Zyl > Founder, Takari and Apache Maven > http://twitter.com/jvanzyl > http://twitter.com/takari_io > --------------------------------------------------------- > > The most dangerous risk: spending your life not doing what you want on the > bet you can buy yourself freedom to do it later. > > -- Randy Komisar > > > > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
