here are a few comments on why ive added that <inclusions> thingy. first let me say i dont actually think it would be a nice solution (as i pointed it in the patch). i also agree that entities stuff are error-prone especially in a multiproject context (i have indeed experimented inconsistent behaviour dependending on where the build is triggered). however my point was to merge arbitrary fragments, not just poms.
indeed oned like to modularize the pom and break it into smaller entities (f.i say one fragment for <developers> b/c there are 30 developers working on my project, one fragment for the <versions> b/c the ci process tags every nigth, etc. please select the relevant examples ;). breaking pom into smaller, independent parts and how the cut is done is ultimately the team responsibility (or is not ?). if one knows for sure that an included file is relative to ${pom.file.parent} then it doesnot depend anymore on the user's workspace (however it still depends on the project structure like any other resources). what michal describes (correct me if im wrong) lacks imho crucial flexibilty and misses the point : included content might (surely) not be defined in other poms (at least not in the way one might want it).
also from the mailing list this inclusion issue seems to be recurrent issue. so perhaps a "HowAndWhyPomShouldnotDeclareXmlEntities" wiki entry could be useful. however i obviously cannot be the one creating it ;)
regards,
-- gd
Rafal Krzewski wrote:
Maczka Michal wrote:
So what I am saying is that we should be only merging POMs not arbitrary XMLVery good point. I personaly hate SGML entities mockery with all my heart - it's so ugly and so fragile! As for explicit inclusion of XML bits, problems arise when they are used acorss multiple projects - you either have to depend on the directory layout in the users workspace, or depend on Maven's local repository layout. This is better, but far from perfect. Solving this through POM dependencies is by far superior to other alternatives. The tricky part is the merge logic and control though.
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
