Hi Anders,

is this kind clear enough:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1.056s
[INFO] Finished at: Mon Apr 04 21:44:12 CEST 2016
[INFO] Final Memory: 9M/245M
[INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-jar-plugin:3.0.0-SNAPSHOT:jar (default-jar) on project maven-jar-plugin-test-mjar-210: You are using 'useDefaultManifestFile' which has been removed from the maven-jar-plugin. Please see the >>Major Version Upgrade to version 3.0.0<< on the plugin site. -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-jar-plugin:3.0.0-SNAPSHOT:jar (default-jar) on project maven-jar-plugin-test-mjar-210: You are using 'useDefaultMenifestFile' which has been removed from the maven-jar-plugin. Please see the >>Major Version Upgrade to version 3.0.0<< on the plugin site. at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:216) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)


WDYT ?

Kind regards
Karl Heinz



On 4/4/16 9:13 PM, Anders Hammar wrote:
Keeping the parameter as deprecated but having it issue an exception could
simplify for the users. WDYT?


Sure make sense ...so i will add the behaviour to the jar-plugin...


Great Karl! Please make sure the deprecated text clearly states that the
param is no more supported (deprecated typically means it still works).

We will surely run into more cases like this (for example MEAR-228).

/Anders








/Anders


---------- Forwarded message ----------
From: Anders Hammar (JIRA) <[email protected]>
Date: Mon, Apr 4, 2016 at 8:50 PM
Subject: [jira] [Commented] (MJAR-210) Remove useDefaultManifestFile
parameter
To: [email protected]



      [

https://issues.apache.org/jira/browse/MJAR-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224801#comment-15224801
]

Anders Hammar commented on MJAR-210:
------------------------------------

Just an idea, should we keep params that we want to remove but mark them
as
deprecated and have them issue an exception with a good error message? To
simplify for people upgrading and catch these breaking changes.

Remove useDefaultManifestFile parameter
---------------------------------------

                  Key: MJAR-210
                  URL: https://issues.apache.org/jira/browse/MJAR-210
              Project: Maven JAR Plugin
           Issue Type: Improvement
     Affects Versions: 3.0.0
             Reporter: Karl Heinz Marbaise
             Assignee: Karl Heinz Marbaise
              Fix For: 3.0.0


The following:
{code}
@Parameter( property = "maven.jar.useDefaultManifestFile", defaultValue =

"false" )

private boolean useDefaultManifestFile;
{code}
does not make sense in general, cause it can be handled via

[MavenArchiver|http://maven.apache.org/shared/maven-archiver/index.html]
configuration. So this should be completely removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)




---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]





Mit freundlichem Gruß
Karl-Heinz Marbaise
--
SoftwareEntwicklung Beratung Schulung    Tel.: +49 (0) 2405 / 415 893
Dipl.Ing.(FH) Karl-Heinz Marbaise        USt.IdNr: DE191347579
Hauptstrasse 177
52146 Würselen                           http://www.soebes.de

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to