GitHub user august782 opened a pull request:
https://github.com/apache/maven/pull/85
Removing redundant test
In FileSizeFormatTest, the two tests testProgressedSizeWithZeroSize and
testProgressedSizeZeroAndSizeZero are exactly the same, so one of them should
be deleted. This pull request deletes testProgressedSizeWithZeroSize.
From looking at the test names, it seems testProgressedSizeWithZeroSize is
supposed to be testing formatProgress with the first parameter being non-zero.
However, having the first parameter being non-zero while the second parameter
being zero results in an IllegalArgumentException, similar to what is being
tested in testNegativeProgressedSizeBiggerThanSize.
If deleting this test is no good, then perhaps it should be changed to
testing the first parameter being non-zero and second parameter being zero, and
then expecting an IllegalArgumentException. This might still overlap with
testNegativeProgressedSizeBiggerThanSize.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/august782/maven removetest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven/pull/85.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #85
----
commit 14c9a9116c335632bc469fcd9591a26f78410e5d
Author: August Shi <[email protected]>
Date: 2016-05-27T22:52:55Z
Removing redundant test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
