good concern Here is my personal analysis on this important topic
Until now, our full color strategy was based on logging implementation: then logging implementation was a strategic choice But the current strategy is now to put color in messages, independantly from logging implementation: see MNG-3507, implemented without anything done at logging provider level. This brings us to one new strategic dependency addition to Maven core: JAnsi, that we expect plugins to use when adding color details to their messages (for example MSITE-779, MINVOKER-205 or SUREFIRE-1254 to start, but I imagine other plugins will do such improvement in the future). Then the strategic question is about JAnsi dependency: this lib seems to me the de-facto answer for Java people, then the right choice for Maven core. Regarding slf4j logging provider, the only expectation we have is to put color on printed loggging level: nothing strategic, no impact on any plugin or extension. Then this Gossip slf4j provider works well, with nice error rendering improvement: that's sufficient for me. And if we have any issue in the future, I see one simple solution: just implement a basic slf4j provider at Maven level, since we really need only basic console logging, withtout much features: even Gossip slf4j provider does 10 times too much for us. The choice we won't be able to change in the future is Jansi. Slf4j provider can be changed any time in the future (and I expect to continue to maintain other providers integrations to prepare scenari where people want to use full-blown provider with Maven) Regards, Hervé Le dimanche 12 juin 2016 09:52:20 Olivier Lamy a écrit : > Hi, > This looks to be a nice feature! > I have more concern on this new dependency. > Do we really want to depend on a single person project? [1] > What is the future of this project? If I look at the history groupId > namespace has changed recently from org.sonatype to com.planet57. [2] > So is it stable (in term of namespace etc...), what will happen in case of > issues etc.... > I just want we avoid similar issues we had in the past (aether..) > > Cheers > Olivier > > [1] https://github.com/jdillon/gossip/graphs/contributors > [2] > https://github.com/jdillon/gossip/commit/1682fd2ba551a7c094ab71dae44c5b26999 > 2fa06 > On 11 June 2016 at 21:26, <[email protected]> wrote: > > Repository: maven > > > > Updated Branches: > > refs/heads/master 427f18c3a -> 644ac9c40 > > > > [MNG-6038] use Gossip slf4j provider (with level color support) > > > > Project: http://git-wip-us.apache.org/repos/asf/maven/repo > > Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/644ac9c4 > > Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/644ac9c4 > > Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/644ac9c4 > > > > Branch: refs/heads/master > > Commit: 644ac9c40ad41bf61e3b099918af33b8eb950621 > > Parents: 427f18c > > Author: Hervé Boutemy <[email protected]> > > Authored: Sat Jun 11 13:26:05 2016 +0200 > > Committer: Hervé Boutemy <[email protected]> > > Committed: Sat Jun 11 13:26:05 2016 +0200 > > > > ---------------------------------------------------------------------- > > > > apache-maven/pom.xml | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > ---------------------------------------------------------------------- > > > > > > > > http://git-wip-us.apache.org/repos/asf/maven/blob/644ac9c4/apache-maven/po > > m.xml > > ---------------------------------------------------------------------- > > diff --git a/apache-maven/pom.xml b/apache-maven/pom.xml > > index 9405df8..37751cc 100644 > > --- a/apache-maven/pom.xml > > +++ b/apache-maven/pom.xml > > @@ -92,8 +92,8 @@ under the License. > > > > <artifactId>aether-transport-wagon</artifactId> > > > > </dependency> > > <dependency> > > > > - <groupId>org.slf4j</groupId> > > - <artifactId>slf4j-simple</artifactId> > > + <groupId>com.planet57.gossip</groupId> > > + <artifactId>gossip-slf4j</artifactId> > > > > </dependency> > > > > </dependencies> --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
