On Sat, Jun 11, 2016 at 5:46 PM, Michael Osipov <[email protected]> wrote:
> Am 2016-06-11 um 15:25 schrieb Anders Hammar: > >> Even if this (breaking) change is for v3.0.0 of the plugin, I'm missing >> some clear docs about how it is supposed to work from now on. Specifically >> for the plugin I assume that the idea is that the release profile to use >> should be specified explicitly? Also, if the releaseProfile in the >> super-POM is to be removed, is the idea that EVERYONE should create their >> own release profile and specify it in their (corporate's/organization's) >> parent POM? >> > > You just have answered your question yourself. This is how you shall do > it. Here is a sample of a release profile [1]: michael-o-release > > [1] > https://repo1.maven.org/maven2/net/sf/michael-o/michael-o-parent/9/michael-o-parent-9.pom I doubt that most corporations (that only deploy to an internal repo) have their own release profile today but rely on the one in the super-POM and also the default setting of m-release-p to use that. So this change in m-release-p is a rather big one and we should document this best-practice and explain what and how to configure. /Anders > > > On Sat, Jun 11, 2016 at 9:10 AM, Karl Heinz Marbaise <[email protected]> >> wrote: >> >> Ah sorry... >>> >>> did saw this issue is already scheduled on 3.0... >>> >>> Kind regards >>> Karl Heinz >>> >>> On 6/11/16 9:00 AM, Karl Heinz Marbaise wrote: >>> >>> Hi, >>>> >>>> This will break backward compatibility in a minor version which is not a >>>> good idea..This something for 3.0.0 .... >>>> >>>> Marking as deprecated good idea...but changing the default...Hm.. >>>> >>>> Kind regards >>>> Karl Heinz Marbaise >>>> >>>> >>>> On 6/10/16 11:20 PM, [email protected] wrote: >>>> >>>> Author: michaelo >>>>> Date: Fri Jun 10 21:20:33 2016 >>>>> New Revision: 1747802 >>>>> >>>>> URL: http://svn.apache.org/viewvc?rev=1747802&view=rev >>>>> Log: >>>>> [MRELEASE-896] Disable and deprecate useReleaseProfile parameter >>>>> >>>>> Submitted-by: Stefan Ferstl >>>>> >>>>> This closes #6 >>>>> >>>>> Modified: >>>>> >>>>> >>>>> >>>>> maven/release/trunk/maven-release-plugin/src/it/projects/perform/MRELEASE-459/pom.xml >>>>> >>>>> >>>>> >>>>> >>>>> maven/release/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PerformReleaseMojo.java >>>>> >>>>> >>>>> Modified: >>>>> >>>>> >>>>> maven/release/trunk/maven-release-plugin/src/it/projects/perform/MRELEASE-459/pom.xml >>>>> >>>>> URL: >>>>> >>>>> >>>>> http://svn.apache.org/viewvc/maven/release/trunk/maven-release-plugin/src/it/projects/perform/MRELEASE-459/pom.xml?rev=1747802&r1=1747801&r2=1747802&view=diff >>>>> >>>>> >>>>> >>>>> ============================================================================== >>>>> >>>>> --- >>>>> >>>>> >>>>> maven/release/trunk/maven-release-plugin/src/it/projects/perform/MRELEASE-459/pom.xml >>>>> (original) >>>>> +++ >>>>> >>>>> >>>>> maven/release/trunk/maven-release-plugin/src/it/projects/perform/MRELEASE-459/pom.xml >>>>> Fri Jun 10 21:20:33 2016 >>>>> @@ -57,6 +57,7 @@ >>>>> </dependency> >>>>> </dependencies> >>>>> <configuration> >>>>> + <useReleaseProfile>true</useReleaseProfile> >>>>> <releaseProfiles>custom-release</releaseProfiles> >>>>> </configuration> >>>>> </plugin> >>>>> >>>>> Modified: >>>>> >>>>> >>>>> maven/release/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PerformReleaseMojo.java >>>>> >>>>> URL: >>>>> >>>>> >>>>> http://svn.apache.org/viewvc/maven/release/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PerformReleaseMojo.java?rev=1747802&r1=1747801&r2=1747802&view=diff >>>>> >>>>> >>>>> >>>>> ============================================================================== >>>>> >>>>> --- >>>>> >>>>> >>>>> maven/release/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PerformReleaseMojo.java >>>>> (original) >>>>> +++ >>>>> >>>>> >>>>> maven/release/trunk/maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PerformReleaseMojo.java >>>>> Fri Jun 10 21:20:33 2016 >>>>> @@ -107,7 +107,8 @@ public class PerformReleaseMojo >>>>> * >>>>> * @deprecated The release profile will be removed from future >>>>> versions of the super POM >>>>> */ >>>>> - @Parameter( defaultValue = "true", property = "useReleaseProfile" >>>>> ) >>>>> + @Parameter( defaultValue = "false", property = >>>>> "useReleaseProfile" ) >>>>> + @Deprecated >>>>> private boolean useReleaseProfile; >>>>> >>>>> /** >>>>> >>>>> >>>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>> >>> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
