Hi, > DEBUG/INFO/WARNING/ERROR schemes I'm thinking at: > 1. bold cyan/bold green/bold yellow/bold red (initial) > 2. bold cyan/bold blue/bold yellow/bold red (current) > 3. cyan/blue/bold yellow/bold red (idea to have INFO less visible)
I prefer to use the standard console color (customised by user) for INFO instead of assign a fix color on that. Most of the time the output is like I want and the bold yellow/red are eye-catcher. Personally, I don't need a custom color for DEBUG. If maven run in DEBUG mode almost 90% of the output is colored. And if this color ist different to my own customized console color it's maybe unconfortable for me to read. My suggestion: DEBUG/INFO: leave as is, maybe make DEBUG bold but don’t change the color. WARNING: bold yellow ERROR: bold red Regards, -- barthel > On 15 Jun 2016, at 08:19, Hervé BOUTEMY <herve.bout...@free.fr> wrote: > > Sorry guys, I did this while looking at a soccer match :) , not on my main > computer, then without communicating... > > This one is a little bit like the Jenkins debate on the green vs blue bullet: > this time, this was a remark on MNG-3507 that bold green on every INFO was > too > much... Then I found that bold Cyan DEBUG + bold Blue INFO was not a bad idea. > But I have no strong opinion: this was a test, before we get too much habit > with the initial implemented colors. > > > On making colors configurable: > - log level color configuration would be feasible, since only the logger has > to implement it: but I don't expect much value, since it's only about > DEBUG/INFO/WARNING/ERROR, then does it really deserve added complexity? > - message level color configuration would be more complex, since this would > require an API to be used by plugins: for this one, I strongly think we > should > at least wait a little bit before trying (and I'm not yet convinced this will > be useful) > > > Perhaps we should make tests on log level color and publish results to > compare > on the Wiki with screenshots. IMHO, for each configuration we'd need > screenshots in misc configurations to check our main targets: > - Linux vs Windows vs OSX > - white background vs black background > - success default vs success -X vs failure (perhaps prepare a reference build) > > DEBUG/INFO/WARNING/ERROR schemes I'm thinking at: > 1. bold cyan/bold green/bold yellow/bold red (initial) > 2. bold cyan/bold blue/bold yellow/bold red (current) > 3. cyan/blue/bold yellow/bold red (idea to have INFO less visible) > > Ready to work with me on that? > (and that could prepare some documentation on our color scheme) > > Regards, > > Hervé > > Le mercredi 15 juin 2016 08:03:58 Olivier Lamy a écrit : >> On 15 June 2016 at 05:25, <hbout...@apache.org> wrote: >>> Repository: maven >>> >>> Updated Branches: >>> refs/heads/master ecdb0bc2b -> e7a783db1 >>> >>> [MNG-3507] keep green for success: INFO in blue (DEBUG is cyan) >>> >>> Project: http://git-wip-us.apache.org/repos/asf/maven/repo >>> Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/e7a783db >>> Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/e7a783db >>> Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/e7a783db >>> >>> Branch: refs/heads/master >>> Commit: e7a783db1f577a340a91f6c958f1b9319c52c176 >>> Parents: ecdb0bc >>> Author: Hervé Boutemy <hbout...@apache.org> >>> Authored: Tue Jun 14 21:25:02 2016 +0200 >>> Committer: Hervé Boutemy <hbout...@apache.org> >>> Committed: Tue Jun 14 21:25:02 2016 +0200 >>> >>> ---------------------------------------------------------------------- >>> >>> .../org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> ---------------------------------------------------------------------- >>> >>> >>> >>> http://git-wip-us.apache.org/repos/asf/maven/blob/e7a783db/maven-embedder/ >>> src/main/java/org/apache/maven/cli/logging/impl/gossip/ColorRenderer.java >>> ---------------------------------------------------------------------- >>> diff --git >>> a/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/Co >>> lorRenderer.java >>> b/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/C >>> olorRenderer.java index 00007cc..52e0489 100644 >>> --- >>> a/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/Co >>> lorRenderer.java +++ >>> b/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/gossip/Co >>> lorRenderer.java @@ -50,7 +50,7 @@ extends >>> com.planet57.gossip.render.PatternRenderer> >>> break; >>> >>> case INFO: >>> - buff.append( ansi().bold().fgGreen().a( level.name() >>> ).reset() ); >>> + buff.append( ansi().bold().fgBlue().a( level.name() >>> ).reset() ); >> >> What about having color configurable? Ask few people they will all have >> different opinions about the color to use. >> So to avoid all of complains and jira issue asking color change etc... >> having some configuration could IMHO ease our life :-) (french part you >> know "les goûts et les couleurs" :-) ) >> >> Well not sure how as the current configuration file is included in the jar. >> Furthermore I have no idea our externalise that. >> >>> break; >>> >>> case WARN: > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
